-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update dependency axios to v1.3.1 #632
Conversation
I got hit by this bug: axios/axios#5346 that 🙏 Thanks for the awesome work Nest.js team! |
Same issue here; would love to see this merged and released; |
Same issue here, leaving comment to get notified when this is merged thanks |
@juanmendez90 Any update on time to merge of this PR? |
Hey, you can use |
would love to see this merged 😄 , commenting to receive notification. |
Hey, @kamilmysliwiec this upgrade looks pretty hot to merge and release it. Could you take a quick look and merge it? |
@kamilmysliwiec Can you merge this PR? |
Crucial for us over here as well |
@kamilmysliwiec can you merge this PR please |
@kamilmysliwiec is there any ETA for this? |
8e53ca0
to
ea2e700
Compare
Please merge this MR, version 1.0.1 contains axios 1.2.1 have the previously cited bug |
@kamilmysliwiec can you merge this PR please |
I'm stuck, any workaround? I've tried to force the version of axios on package.json to 1.2.3 but no success at all. |
I've downgraded the version to 0.1.0, it works |
@joaomantovani add it in resolutions in your package, at least as a workaround. "dependencies": {
...
},
"resolutions": {
"axios": "1.2.3"
}, |
ea2e700
to
84b00cd
Compare
for yarn users with workspaces set
|
@kamilmysliwiec we can merege this already. It fixes issues on |
It'll also resolve problem with http health check indicator on |
84b00cd
to
1c1d77d
Compare
@kamilmysliwiec sorry for the tag, but this is a pretty big breaking issue with the latest versions of |
In the
{
"overrides": {
"axios": "1.2.5"
}
} |
1c1d77d
to
1269fc9
Compare
1269fc9
to
23b2285
Compare
23b2285
to
56e79a1
Compare
any ETA when will this PR able to get merge and available in the new version of nests/axios? |
when will the package update be available? |
@juanmendez90 @Tony133 @micalevisk any ETA on when this will be merged? It's been open for a month now and the version of Axios used |
When does this update go live? It's still |
Hi @doughlass, The automatic renovate merge has been disabled because otherwise it was already merged. So you have to do the merge manually, but I think it's been disabled due to major changes that can happen with newer versions of axios, if I'm not mistaken one happened during the upgrade from version |
Thank you for the reply @Tony133 hopefully Renovate Merge can be configured to auto merge minor and patch and leave future major dependancy merges a manual job. |
This PR contains the following updates:
1.2.1
->1.3.1
Release Notes
axios/axios
v1.3.1
Compare Source
Bug Fixes
Contributors to this release
v1.3.0
Compare Source
Bug Fixes
Features
Contributors to this release
1.2.6 (2023-01-28)
Bug Fixes
CommonRequestHeadersList
&CommonResponseHeadersList
types to be private in commonJS; (#5503) (5a3d0a3)Contributors to this release
1.2.5 (2023-01-26)
Bug Fixes
Contributors to this release
1.2.4 (2023-01-22)
Bug Fixes
RawAxiosRequestConfig
back toAxiosRequestConfig
; (#5486) (2a71f49)AxiosRequestConfig
generic; (#5478) (9bce81b)Contributors to this release
1.2.3 (2023-01-10)
Bug Fixes
Contributors to this release
[1.2.2] - 2022-12-29
Fixed
Chores
Contributors to this release
[1.2.1] - 2022-12-05
Changed
Fixed
Refactors
Chores
Contributors to this release
[1.2.0] - 2022-11-10
Changed
Fixed
Refactors
Chores
Contributors to this release
[1.1.3] - 2022-10-15
Added
Fixed
Chores
Contributors to this release
[1.1.2] - 2022-10-07
Fixed
Contributors to this release
[1.1.1] - 2022-10-07
Fixed
Contributors to this release
[1.1.0] - 2022-10-06
Fixed
Contributors to this release
[1.0.0] - 2022-10-04
Added
Changed
Deprecated
Removed
Fixed
Chores
Security
Contributors to this release
v1.2.6
Compare Source
Bug Fixes
CommonRequestHeadersList
&CommonResponseHeadersList
types to be private in commonJS; (#5503) (5a3d0a3)Contributors to this release
v1.2.5
Compare Source
Bug Fixes
Contributors to this release
v1.2.4
Compare Source
Bug Fixes
RawAxiosRequestConfig
back toAxiosRequestConfig
; (#5486) (2a71f49)AxiosRequestConfig
generic; (#5478) (9bce81b)Contributors to this release
v1.2.3
Compare Source
Bug Fixes
Contributors to this release
v1.2.2
Compare Source
Fixed
Chores
Contributors to this release
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.