fix serialize Struct, now Struct is not a collection #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nesaulov
requested changes
Mar 5, 2019
Repository owner
deleted a comment from
0exp
Mar 5, 2019
Repository owner
deleted a comment from
0exp
Mar 5, 2019
nesaulov
requested changes
Mar 7, 2019
spec/helper_spec.rb
Outdated
| describe 'serializing a single struct' do | ||
| let(:person) { TestStruct.new('John', 'Dow') } | ||
|
|
||
| it 'raise surrealize instead surrealize_collection with struct' do |
There was a problem hiding this comment.
everything seems good, but the example message is quite misleading: nothing is raised, we are just asserting that SurrealistHelper.collection? returns false for a single struct
I suggest something like specify 'a struct is not treated as a collection' do ...
nesaulov
approved these changes
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correction of behavior during serialization Struct. Now Struct is perceived as a single object, not a collection.