Allow hash surrealization #106
Conversation
spec/build_schema_spec.rb
Outdated
|
|
||
| context 'root hash with object inside' do | ||
| specify do | ||
| expect(HashRoot.new({nested: OpenStruct.new(real: 1, imaginary: -1)}).build_schema).to eq({nested: { real: 1, imaginary: -1}}) |
There was a problem hiding this comment.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Style/BracesAroundHashParameters: Redundant curly braces around a hash parameter.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Metrics/LineLength: Line is too long. [134/110]
spec/build_schema_spec.rb
Outdated
|
|
||
| context 'deep hash arg' do | ||
| specify do | ||
| expect(DeepHash.new({list: [1, 2], nested: { right: 4, left: 'three'}}).build_schema).to eq({list: [1, 2], nested: { right: 4, left: 'three'}}) |
There was a problem hiding this comment.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Style/BracesAroundHashParameters: Redundant curly braces around a hash parameter.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
Metrics/LineLength: Line is too long. [151/110]
spec/build_schema_spec.rb
Outdated
| RSpec.describe Surrealist do | ||
| describe '#build_schema' do | ||
| context 'with hash arg' do | ||
| specify do | ||
| expect(ComplexNumber.new({real: 1, imaginary: 2}).build_schema).to eq(real: 1, imaginary: 2) |
There was a problem hiding this comment.
Layout/SpaceInsideHashLiteralBraces: Space inside { missing.
Style/BracesAroundHashParameters: Redundant curly braces around a hash parameter.
Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
|
@stefkin thank you for the PR! |
spec/serializer_spec.rb
Outdated
| it { is_expected.to eq expectation } | ||
| end | ||
|
|
||
| describe "#surrealize with camelize" do |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
spec/serializer_spec.rb
Outdated
| it { is_expected.to eq expectation } | ||
| end | ||
|
|
||
| describe "#surrealize with include root" do |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
spec/serializer_spec.rb
Outdated
| let(:flour) { Struct.new(:amount).new(40) } | ||
| let(:instance) { { color: 'yellow', amount: 60 } } | ||
|
|
||
| describe "#surrealize" do |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
|
@nesaulov I've added a couple of tests using #surrealize with different args and fixed cops. |
Related issue: #96
Since version in master traverses hashes just fine when they're located deeper in object tree the issue with Hashes appears only when root object in a Hash. Instead of creating a HashBuilder for pure hashes, I tried to fix the existing process to allow surrealization of mixed data structures with Hash in the root.
Hash was misinterpreted as a collection by Helper#collection? and ValueAssigner#raw_value doesn't peek into instance's object while trying to extract value with Hash#[].
I tried to fix that in an ad-hoc manner, I hope it's not too bad.
I think it would be better to rework value extraction in ValueAssigner, but I'm afraid value extraction logic can become too messy.
Anyway, I'm ready to discuss a better approach to resolve the issue.