-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TrieTree implementation #34
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* TrieTree -- A compacted SparseMerkleTree
* Removed unused code, fix warnings, code path tweaking * Merkle Proof implementation(inclusion&exclusion), compatible with original one
TheWaWaR
reviewed
Nov 11, 2022
TheWaWaR
reviewed
Nov 11, 2022
TheWaWaR
reviewed
Nov 11, 2022
TheWaWaR
reviewed
Nov 11, 2022
TheWaWaR
reviewed
Nov 11, 2022
TheWaWaR
reviewed
Nov 11, 2022
TheWaWaR
reviewed
Nov 11, 2022
1. use get_bit for a more clearfy operation 2. ignore height to make less confusion Co-authored-by: LinFeng <[email protected]>
TheWaWaR
reviewed
Nov 11, 2022
quake
reviewed
Nov 12, 2022
Co-authored-by: Quake Wang <[email protected]>
TheWaWaR
reviewed
Nov 14, 2022
TheWaWaR
reviewed
Nov 14, 2022
TheWaWaR
reviewed
Nov 14, 2022
TheWaWaR
reviewed
Nov 14, 2022
quake
approved these changes
Nov 14, 2022
Others just look good to me, I'll approve if all above comments resolved. |
TheWaWaR
approved these changes
Nov 17, 2022
TheWaWaR
requested changes
Nov 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add test case for zero-value shortcut issue
TheWaWaR
approved these changes
Nov 17, 2022
…th's height == 0, MergeValue::shortcut should be MergeValue::Value
* refactor: improve shortcut node builds logic and into_merge_value * Apply suggestions from code review Co-authored-by: Quake Wang <[email protected]> * chore: fix build fail Co-authored-by: Quake Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings a new implementation for
SparseMerkleTree
(check trie_tree.rs), typically called TrieTree, which is:MerkleProof
&Compiled MerkleProof
Reference
Read/Write performace comparison:
Here's some bench data with rw operations counters
This can reproduced by the benchmark : benches/store_counter_benchmark.rs
with command:
cargo bench --features trie -- --test
andcargo bench -- --test
New
Original