Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase #334 by @xying21 #359

Closed
wants to merge 12 commits into from
Closed

Rebase #334 by @xying21 #359

wants to merge 12 commits into from

Conversation

doitian
Copy link
Member

@doitian doitian commented Aug 3, 2022

Rebase #334 on to master

@doitian doitian requested a review from janx August 3, 2022 03:10
@doitian doitian requested a review from a team as a code owner August 3, 2022 03:10
doitian and others added 7 commits August 29, 2022 14:28
…-allow-script-multiple-matches-on-identical-code.md

Co-authored-by: busyforking <[email protected]>
…-allow-script-multiple-matches-on-identical-code.md

Co-authored-by: busyforking <[email protected]>
…-allow-script-multiple-matches-on-identical-code.md

Co-authored-by: busyforking <[email protected]>
@doitian
Copy link
Member Author

doitian commented Aug 29, 2022

The PR is too huge to review.

@doitian doitian closed this Aug 29, 2022
@janx
Copy link
Member

janx commented Aug 29, 2022

This PR is closed due to its limited value and huge review efforts required.

I suggest splitting it into multiple small PRs, each PR improves one RFC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants