Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rfc(0017): revise since RFC #226

Merged
merged 15 commits into from
Sep 14, 2022
Merged

rfc(0017): revise since RFC #226

merged 15 commits into from
Sep 14, 2022

Commits on Aug 19, 2022

  1. Revise Since RFC. 

    - Use more precise description.
- Add diagrams and remove codes.
- Fix errors:
* The timestamp is in the unit milliseconds but not seconds.
* There are many errors where `<=` is expected but `<` is used or
vise versa.
* The Rust code base implementation has many gotchas and must be
considered as the part of consensus.
    @doitian
    doitian committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    f694449 View commit details
    Browse the repository at this point in the history

  2. Add a link to the diagrams in LucidChart

    @doitian
    doitian committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    ddbac62 View commit details
    Browse the repository at this point in the history

  3. When L is 0, E + I / L is considered as E + 0 / 1

    @doitian
    doitian committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    4754ab1 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review

    @doitian
    doitian committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    463b349 View commit details
    Browse the repository at this point in the history

  5. Update rfcs/0017-tx-valid-since/0017-tx-valid-since.md 

    Co-authored-by: busyforking <[email protected]>
    @doitian @janx
    doitian and janx committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    fe1a3d2 View commit details
    Browse the repository at this point in the history

  6. Update rfcs/0017-tx-valid-since/0017-tx-valid-since.md 

    Co-authored-by: busyforking <[email protected]>
    @doitian @janx
    doitian and janx committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    00c0f66 View commit details
    Browse the repository at this point in the history

  7. Update rfcs/0017-tx-valid-since/0017-tx-valid-since.md 

    Co-authored-by: busyforking <[email protected]>
    @doitian @janx
    doitian and janx committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    99ad55d View commit details
    Browse the repository at this point in the history

  8. Update rfcs/0017-tx-valid-since/0017-tx-valid-since.md 

    Co-authored-by: busyforking <[email protected]>
    @doitian @janx
    doitian and janx committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    be9cf99 View commit details
    Browse the repository at this point in the history

  9. rewrite tx valid since summary

    @doitian
    doitian committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    7a4abe4 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2022

  1. rewrite the RFC using the term since precondition

    @doitian
    doitian committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    d37c06e View commit details
    Browse the repository at this point in the history

  2. fix spell check errors and improve the grammar

    @doitian
    doitian committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    49ab228 View commit details
    Browse the repository at this point in the history

  3. fix a markdown link

    @doitian
    doitian committed Aug 22, 2022
    Configuration menu
    Copy the full SHA
    eda686c View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2022

  1. Update rfcs/0017-tx-valid-since/0017-tx-valid-since.md 

    Co-authored-by: busyforking <[email protected]>
    @doitian @janx
    doitian and janx authored Aug 29, 2022
    Configuration menu
    Copy the full SHA
    b576613 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2022

  1. Merge branch 'revise-since-rfc' of https://github.com/doitian/rfcs in… 

    …to revise-since-rfc.
    @jordanmack
    jordanmack committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    c445d1b View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2022

  1. Merge pull request #2 from jordanmack/revise-since-rfc 

    Revise Since RFC text.
    @doitian
    doitian authored Sep 13, 2022
    Configuration menu
    Copy the full SHA
    41d8ca1 View commit details
    Browse the repository at this point in the history