Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove unexpected value in log #3224

Merged
merged 1 commit into from
Aug 7, 2024
Merged

fix: Remove unexpected value in log #3224

merged 1 commit into from
Aug 7, 2024

Conversation

yanguoyu
Copy link
Collaborator

@yanguoyu yanguoyu commented Aug 6, 2024

No description provided.

@yanguoyu yanguoyu force-pushed the fix-remove-extend-key branch from 0c4c534 to f15bf4e Compare August 6, 2024 04:39
@Keith-CY
Copy link
Collaborator

Keith-CY commented Aug 6, 2024 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 10261174393. @Keith-CY

@silySuper
Copy link
Collaborator

When import same extened public key it shows
截屏2024-08-06 17 35 20
video:

2024-08-06.17.33.17.mov

But watch wallet in expect it should shows:
截屏2024-08-06 17 35 59
pr:
Magickbase/neuron-public-issues#380

@yanguoyu yanguoyu force-pushed the fix-remove-extend-key branch from f15bf4e to 912602f Compare August 6, 2024 09:54
@yanguoyu
Copy link
Collaborator Author

yanguoyu commented Aug 6, 2024

fix: Remove unexpected value in log

fixed

@yanguoyu yanguoyu requested review from Keith-CY and homura August 6, 2024 09:55
@yanguoyu
Copy link
Collaborator Author

yanguoyu commented Aug 6, 2024 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 10264337352. @yanguoyu

@silySuper
Copy link
Collaborator

When import same extened public key and not watch wallet(which was created by keystore) it shows
截屏2024-08-07 09 51 24

video:

2024-08-07.09.53.31.mov

But not watch wallet in expect it should shows:
截屏2024-08-06 17 35 20

@yanguoyu
Copy link
Collaborator Author

yanguoyu commented Aug 7, 2024 •
edited
Loading

When import same extened public key and not watch wallet(which was created by keystore) it shows 截屏2024-08-07 09 51 24

video:

2024-08-07.09.53.31.mov
But not watch wallet in expect it should shows: 截屏2024-08-06 17 35 20

When importing a duplicate watched wallet, from #3214 (comment) this video always shows replace it. @silySuper

@yanguoyu yanguoyu force-pushed the fix-remove-extend-key branch from 912602f to ef4d9e2 Compare August 7, 2024 03:19
@yanguoyu
Copy link
Collaborator Author

yanguoyu commented Aug 7, 2024

When import same extened public key and not watch wallet(which was created by keystore) it shows 截屏2024-08-07 09 51 24

video:

2024-08-07.09.53.31.mov
But not watch wallet in expect it should shows: 截屏2024-08-06 17 35 20

fixed

@yanguoyu
Copy link
Collaborator Author

yanguoyu commented Aug 7, 2024 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 10277565644. @yanguoyu

@yanguoyu
Copy link
Collaborator Author

yanguoyu commented Aug 7, 2024

@Keith-CY @homura @devchenyan Please have a review

@yanguoyu yanguoyu added this pull request to the merge queue Aug 7, 2024
Merged via the queue into nervosnetwork:develop with commit 4e46d03 Aug 7, 2024
10 checks passed
@yanguoyu yanguoyu deleted the fix-remove-extend-key branch August 7, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silySuper silySuper silySuper approved these changes

@homura homura homura approved these changes

@Keith-CY Keith-CY Keith-CY approved these changes

@devchenyan devchenyan Awaiting requested review from devchenyan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yanguoyu @Keith-CY @silySuper @homura