Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support reset lock window password #3197

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

yanguoyu
Copy link
Collaborator

Refer to Magickbase/neuron-public-issues#394

2024-06-25.12.06.22.mov

@Danie0918
Copy link
Collaborator

@devchenyan @homura @twhy Please have a review.

@yanguoyu yanguoyu force-pushed the feat-opt-lock-window branch from 28c6fda to 7edb38a Compare June 26, 2024 05:31
@silySuper
Copy link
Collaborator

silySuper commented Jun 27, 2024

/package
Packageing failed in 9693811938. @silySuper

@silySuper
Copy link
Collaborator

silySuper commented Jun 28, 2024

/package
Packaging for test is done in 9706597667. @silySuper

@silySuper
Copy link
Collaborator

silySuper commented Jun 28, 2024

1.UI is not same with UI document.
actual:
截屏2024-06-28 17 43 01

expect:
截屏2024-06-28 17 43 57

@yanguoyu
Copy link
Collaborator Author

1.UI is not same with UI document. actual: 截屏2024-06-28 17 43 01

expect: 截屏2024-06-28 17 43 57

image

I can not get this UI logic, why did the copy change from Enter the unlock code again to Verify Password when confirming the password failed? I guess these actions should be the same as changing the password on setting pages.
@Danie0918

@Danie0918
Copy link
Collaborator

1.UI is not same with UI document. actual: 截屏2024-06-28 17 43 01
expect: 截屏2024-06-28 17 43 57

image I can not get this UI logic, why did the copy change from `Enter the unlock code again` to `Verify Password` when confirming the password failed? I guess these actions should be the same as changing the password on setting pages. @Danie0918

The prompt here is unnecessary, follow the current implementation and I'll push for UI draft changes. @silySuper

@Keith-CY Keith-CY merged commit 54994c3 into nervosnetwork:develop Jul 1, 2024
10 checks passed
@yanguoyu yanguoyu deleted the feat-opt-lock-window branch July 1, 2024 01:56
@Keith-CY Keith-CY mentioned this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants