Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add a prompt when importing wallets from ckb-cli #3192

Merged
merged 6 commits into from
Jul 1, 2024
Merged

feat: Add a prompt when importing wallets from ckb-cli #3192

merged 6 commits into from
Jul 1, 2024

Conversation

devchenyan
Copy link
Collaborator

issue: Magickbase/neuron-public-issues#354

Screen-2024-06-20-144020.mp4

@devchenyan devchenyan mentioned this pull request Jun 20, 2024
Open
Keith-CY
Keith-CY reviewed Jun 21, 2024
View reviewed changes
packages/neuron-wallet/src/controllers/wallets.ts Show resolved Hide resolved
packages/neuron-ui/src/locales/zh.json Outdated Show resolved Hide resolved
packages/neuron-ui/src/locales/zh-tw.json Outdated Show resolved Hide resolved
packages/neuron-ui/src/locales/es.json Outdated Show resolved Hide resolved
@devchenyan devchenyan requested a review from Keith-CY June 21, 2024 08:07
@Danie0918
Copy link
Collaborator

@yanguoyu @homura @twhy Please have a review.

@devchenyan devchenyan requested a review from silySuper June 26, 2024 22:23
@silySuper
Copy link
Collaborator

silySuper commented Jun 27, 2024 •
edited by github-actions bot
Loading

/package

Packaging for test is done in 9691876721. @silySuper

@Danie0918 Danie0918 removed the request for review from twhy July 1, 2024 03:21
@silySuper
Copy link
Collaborator

silySuper commented Jul 1, 2024 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 9737756838. @silySuper

@Keith-CY Keith-CY added this pull request to the merge queue Jul 1, 2024
Merged via the queue into develop with commit d7018b3 Jul 1, 2024
23 checks passed
@Keith-CY Keith-CY deleted the feat-354 branch July 1, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silySuper silySuper silySuper approved these changes

@yanguoyu yanguoyu yanguoyu approved these changes

@Keith-CY Keith-CY Keith-CY approved these changes

@homura homura Awaiting requested review from homura

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devchenyan @Danie0918 @silySuper @Keith-CY @yanguoyu