Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong sync status when using devnet #3183

Merged
merged 4 commits into from
Jun 12, 2024
Merged

fix: wrong sync status when using devnet #3183

merged 4 commits into from
Jun 12, 2024

Conversation

devchenyan
Copy link
Collaborator

issue: Magickbase/neuron-public-issues#359

nervosnetwork/ckb#4472

sync state only init with local on start, and will update on sync with other node, never with self mined. dev node never has network communicate.

If it is a devnet node, set tip_number to best_known_block_number to avoid showing sync failure.

@devchenyan devchenyan mentioned this pull request Jun 6, 2024
Open
@Danie0918
Copy link
Collaborator

@homura @twhy Please have a review.

homura
homura approved these changes Jun 7, 2024
View reviewed changes
Copy link
Collaborator

@homura homura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I suggest changing the title to 'fix: wrong sync status when using devnet'

@devchenyan devchenyan changed the title fix: Dev network show mistake sync status fix: wrong sync status when using devnet Jun 7, 2024
@devchenyan devchenyan requested a review from silySuper June 7, 2024 12:36
@Keith-CY
Copy link
Collaborator

Keith-CY commented Jun 12, 2024 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 9476055353. @Keith-CY

@Keith-CY
Copy link
Collaborator

@silySuper please check

@Keith-CY Keith-CY merged commit aa100d7 into develop Jun 12, 2024
23 checks passed
@Keith-CY Keith-CY deleted the feat-359 branch June 12, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silySuper silySuper silySuper approved these changes

@yanguoyu yanguoyu yanguoyu approved these changes

@homura homura homura approved these changes

@twhy twhy twhy approved these changes

@Keith-CY Keith-CY Awaiting requested review from Keith-CY

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@devchenyan @Danie0918 @Keith-CY @twhy @homura @yanguoyu @silySuper