Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support set start block number for multisig address #3176

Merged
merged 2 commits into from
Jun 4, 2024
Merged

feat: Support set start block number for multisig address #3176

merged 2 commits into from
Jun 4, 2024

Conversation

yanguoyu
Copy link
Collaborator

2024-05-28.23.15.18.mov

Refer to Magickbase/neuron-public-issues#353

@yanguoyu yanguoyu mentioned this pull request May 28, 2024
Open
@Danie0918 Danie0918 requested a review from twhy May 29, 2024 12:33
@Danie0918
Copy link
Collaborator

@homura @devchenyan @twhy Please have a review.

@Danie0918
Copy link
Collaborator

@homura @devchenyan @twhy Please have a review.

cc @homura @devchenyan @twhy

@silySuper
Copy link
Collaborator

silySuper commented May 31, 2024 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 9314286132. @silySuper

@silySuper
Copy link
Collaborator

When multisig address is syncing,light client node is stop syncing?this requirement is to let multisig address sync can not stoping light client node sync? @Danie0918
截屏2024-05-31 17 33 42

@yanguoyu
Copy link
Collaborator Author

When multisig address is syncing,light client node is stop syncing?this requirement is to let multisig address sync can not stoping light client node sync? @Danie0918 截屏2024-05-31 17 33 42

Magickbase/neuron-public-issues#353 (comment)
When syncing multisig, the wallet sync will stop.

@Danie0918
Copy link
Collaborator

Danie0918 commented May 31, 2024 •
edited
Loading

When multisig address is syncing,light client node is stop syncing?this requirement is to let multisig address sync can not stoping light client node sync? @Danie0918 截屏2024-05-31 17 33 42

Yes, but the display here could be optimized: show 'Sync Pause' or '--' to avoid worrying the user.

BTW, the red alert tip does feel like a bug, and if UI is needed, it's up to me to move forward with the design. @yanguoyu

@silySuper
Copy link
Collaborator

silySuper commented Jun 3, 2024 •
edited by github-actions bot
Loading

/package
Packaging for test is done in 9345190912. @silySuper

@yanguoyu yanguoyu enabled auto-merge June 4, 2024 06:48
@yanguoyu yanguoyu added this pull request to the merge queue Jun 4, 2024
Merged via the queue into nervosnetwork:develop with commit 29ba444 Jun 4, 2024
10 checks passed
@yanguoyu yanguoyu deleted the feat-multi-sync branch June 4, 2024 12:14
@Keith-CY Keith-CY mentioned this pull request Aug 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silySuper silySuper silySuper approved these changes

@devchenyan devchenyan devchenyan approved these changes

@homura homura homura approved these changes

@twhy twhy twhy approved these changes

@Keith-CY Keith-CY Awaiting requested review from Keith-CY

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yanguoyu @Danie0918 @silySuper @twhy @homura @devchenyan