Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor models/multisig with lumos #3156

Merged
merged 5 commits into from
May 21, 2024
Merged

refactor: refactor models/multisig with lumos #3156

merged 5 commits into from
May 21, 2024

Conversation

twhy
Copy link
Contributor

@twhy twhy commented May 20, 2024

No description provided.

@twhy
Copy link
Contributor Author

twhy commented May 21, 2024

@Keith-CY Please trigger workflows and review this when you're available.

packages/neuron-wallet/src/models/multisig.ts Outdated Show resolved Hide resolved
@Keith-CY
Copy link
Collaborator

Keith-CY commented May 21, 2024

/package
Packaging for test is done in 9169990204. @Keith-CY

@twhy
Copy link
Contributor Author

twhy commented May 21, 2024

The original commit was signed but maybe the rebase made it unsigned.
image

@Keith-CY
Copy link
Collaborator

The original commit was signed but maybe the rebase made it unsigned. image

Feel free to force-push to override the unsigned commit

@twhy
Copy link
Contributor Author

twhy commented May 21, 2024

@Keith-CY This PR can be merged now, maybe run the workflows once more.

@Keith-CY Keith-CY added this pull request to the merge queue May 21, 2024
Merged via the queue into nervosnetwork:develop with commit 590dc0d May 21, 2024
9 checks passed
@twhy twhy deleted the refactor-multisig-with-lumos branch May 21, 2024 11:18
yanguoyu added a commit to yanguoyu/neuron that referenced this pull request May 29, 2024
* refactor: refactor models/multisig with lumos

Signed-off-by: Tom Wang <[email protected]>

* refactor: move BLAKE160_HEX_LENGTH to blake2b.ts

Signed-off-by: Tom Wang <[email protected]>

* feat: Add help link for sync failed.

Signed-off-by: Tom Wang <[email protected]>

* ci: upgrade github actions version (nervosnetwork#3161)

Co-authored-by: Chen Yu <[email protected]>
Signed-off-by: Tom Wang <[email protected]>

---------

Signed-off-by: Tom Wang <[email protected]>
Co-authored-by: yanguoyu <[email protected]>
Co-authored-by: Chen Yu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants