Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update depedencies and lock the versions #314

Merged
merged 2 commits into from
May 10, 2019
Merged

feat: update depedencies and lock the versions #314

merged 2 commits into from
May 10, 2019

Conversation

Keith-CY
Copy link
Collaborator

@Keith-CY Keith-CY commented May 9, 2019

No description provided.

@ashchan
Copy link
Contributor

ashchan commented May 10, 2019

Restarted CI build.

ashchan
ashchan suggested changes May 10, 2019
View reviewed changes
Copy link
Contributor

@ashchan ashchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure CI pass.

@duanyytop
Copy link
Contributor

Keys test case fail because of async

@Keith-CY
Copy link
Collaborator Author

CI passed

classicalliu
classicalliu reviewed May 10, 2019
View reviewed changes
packages/neuron-wallet/src/services/transactions.ts
@@ -290,7 +290,7 @@ export default class TransactionsService {
const previousOutputs: OutputEntity[] = []
for (const i of transaction.inputs!) {
const input = new InputEntity()
input.outPointHash = i.previousOutput.hash
input.outPointTxHash = i.previousOutput.txHash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's this version of SDK is still outPoint.txHash or outPoint.cell.txHash ?

Copy link
Collaborator Author

@Keith-CY Keith-CY May 10, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's this version of SDK is still outPoint.txHash or outPoint.cell.txHash ?

pre-release of v0.11, which uses outpoint of { txHash, index }

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i c

@Keith-CY Keith-CY requested a review from ashchan May 10, 2019 02:51
classicalliu
classicalliu reviewed May 10, 2019
View reviewed changes
packages/neuron-wallet/package.json Outdated
@@ -25,7 +25,7 @@
},
"husky": {
"hooks": {
"pre-commit": "lint-staged"
"pre-commit": "lint-staged & yarn test"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

& or &&? But I think test can remove from pre-commit, CI will check it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

&& is correct.

CI usually blocked

@ashchan ashchan merged commit 9af0f21 into nervosnetwork:develop May 10, 2019
Keith-CY pushed a commit that referenced this pull request Dec 10, 2023
@renovate
chore(deps): update dependency lerna to v7.4.2 (#314)
e6c1c43 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this pull request Dec 19, 2023
@Keith-CY @renovate
Bump dependencies (#2980)
6640e21 
* chore(deps): update dependency lerna to v7.4.2 (#314)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency jest-when to v3.6.0 (#313)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency jest-styled-components to v7.2.0 (#312)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/bi to v0.21.0-next.3 (#317)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency eslint-plugin-import to v2.29.0 (#309)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/codec to v0.21.0-next.3 (#319)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/hd to v0.21.0-next.3 (#322)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/common-scripts to v0.21.0-next.3 (#320)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/ckb-indexer to v0.21.0-next.3 (#318)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/config-manager to v0.21.0-next.3 (#321)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency react-i18next to v13.5.0 (#325)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency @babel/core to v7.23.5 (#327)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency typescript to v5.3.3

* chore(deps): update dependency @types/enzyme to v3.10.18 (#328)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore: update reviewers of renovate (#330)

* refactor: introduce tslib

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this pull request Dec 21, 2023
@Keith-CY @renovate
Bump dependencies (#2993)
e0e5578 
* chore(deps): update dependency lerna to v7.4.2 (#314)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency jest-when to v3.6.0 (#313)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency jest-styled-components to v7.2.0 (#312)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/bi to v0.21.0-next.3 (#317)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency eslint-plugin-import to v2.29.0 (#309)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/codec to v0.21.0-next.3 (#319)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/hd to v0.21.0-next.3 (#322)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/common-scripts to v0.21.0-next.3 (#320)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/ckb-indexer to v0.21.0-next.3 (#318)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/config-manager to v0.21.0-next.3 (#321)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency react-i18next to v13.5.0 (#325)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency @babel/core to v7.23.5 (#327)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency typescript to v5.3.3

* chore(deps): update dependency @types/enzyme to v3.10.18 (#328)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore: update reviewers of renovate (#330)

* chore(deps): update dependency @babel/core to v7.23.6

* chore(deps): update dependency eslint-plugin-import to v2.29.1

* refactor: introduce tslib

* chore(deps): update dependency eslint to v8.56.0

* chore(deps): update react monorepo to v18

* chore(deps): update dependency wait-on to v7.2.0

* chore(deps): update dependency webpack to v5.89.0

* chore(deps): update dependency @types/styled-components to v5.1.34

* chore(deps): update node.js to v18.19.0

* refactor: update type declaration for react 18

* chore(deps): update peterjgrainger/action-create-branch action to v2.4.0

* chore(deps): update typescript-eslint monorepo to v5.62.0

* fix(deps): update dependency react-router-dom to v6.21.0

* fix(deps): update dependency sass to v1.69.5

* fix(deps): update dependency undici to v5.28.2

* chore(deps): update storybook monorepo to v7.6.6 (#342)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update actions/checkout action to v4 (#349)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update actions/github-script action to v7 (#350)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency react-i18next to v12.3.1

* chore(deps): update actions/setup-node action to v4

* chore(deps): update actions/stale action to v9

* chore(deps): update actions/upload-artifact action to v4

* chore(deps): update crazy-max/ghaction-import-gpg action to v6 (#355)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore: rollback wait-on because it hangs in tcp connection

---------

Signed-off-by: Chen Yu <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
yanguoyu pushed a commit to yanguoyu/neuron that referenced this pull request Mar 14, 2024
@Keith-CY @renovate @yanguoyu
Bump dependencies (nervosnetwork#2980)
c0b3c64 
* chore(deps): update dependency lerna to v7.4.2 (nervosnetwork#314)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency jest-when to v3.6.0 (nervosnetwork#313)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency jest-styled-components to v7.2.0 (nervosnetwork#312)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/bi to v0.21.0-next.3 (nervosnetwork#317)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency eslint-plugin-import to v2.29.0 (nervosnetwork#309)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/codec to v0.21.0-next.3 (nervosnetwork#319)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/hd to v0.21.0-next.3 (nervosnetwork#322)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/common-scripts to v0.21.0-next.3 (nervosnetwork#320)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/ckb-indexer to v0.21.0-next.3 (nervosnetwork#318)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/config-manager to v0.21.0-next.3 (nervosnetwork#321)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency react-i18next to v13.5.0 (nervosnetwork#325)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency @babel/core to v7.23.5 (nervosnetwork#327)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency typescript to v5.3.3

* chore(deps): update dependency @types/enzyme to v3.10.18 (nervosnetwork#328)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore: update reviewers of renovate (nervosnetwork#330)

* refactor: introduce tslib

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
yanguoyu pushed a commit to yanguoyu/neuron that referenced this pull request Mar 14, 2024
@Keith-CY @renovate @yanguoyu
Bump dependencies (nervosnetwork#2993)
6535978 
* chore(deps): update dependency lerna to v7.4.2 (nervosnetwork#314)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency jest-when to v3.6.0 (nervosnetwork#313)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency jest-styled-components to v7.2.0 (nervosnetwork#312)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/bi to v0.21.0-next.3 (nervosnetwork#317)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency eslint-plugin-import to v2.29.0 (nervosnetwork#309)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/codec to v0.21.0-next.3 (nervosnetwork#319)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/hd to v0.21.0-next.3 (nervosnetwork#322)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/common-scripts to v0.21.0-next.3 (nervosnetwork#320)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/ckb-indexer to v0.21.0-next.3 (nervosnetwork#318)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency @ckb-lumos/config-manager to v0.21.0-next.3 (nervosnetwork#321)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency react-i18next to v13.5.0 (nervosnetwork#325)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency @babel/core to v7.23.5 (nervosnetwork#327)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency typescript to v5.3.3

* chore(deps): update dependency @types/enzyme to v3.10.18 (nervosnetwork#328)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore: update reviewers of renovate (nervosnetwork#330)

* chore(deps): update dependency @babel/core to v7.23.6

* chore(deps): update dependency eslint-plugin-import to v2.29.1

* refactor: introduce tslib

* chore(deps): update dependency eslint to v8.56.0

* chore(deps): update react monorepo to v18

* chore(deps): update dependency wait-on to v7.2.0

* chore(deps): update dependency webpack to v5.89.0

* chore(deps): update dependency @types/styled-components to v5.1.34

* chore(deps): update node.js to v18.19.0

* refactor: update type declaration for react 18

* chore(deps): update peterjgrainger/action-create-branch action to v2.4.0

* chore(deps): update typescript-eslint monorepo to v5.62.0

* fix(deps): update dependency react-router-dom to v6.21.0

* fix(deps): update dependency sass to v1.69.5

* fix(deps): update dependency undici to v5.28.2

* chore(deps): update storybook monorepo to v7.6.6 (nervosnetwork#342)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update actions/checkout action to v4 (nervosnetwork#349)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update actions/github-script action to v7 (nervosnetwork#350)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore(deps): update dependency react-i18next to v12.3.1

* chore(deps): update actions/setup-node action to v4

* chore(deps): update actions/stale action to v9

* chore(deps): update actions/upload-artifact action to v4

* chore(deps): update crazy-max/ghaction-import-gpg action to v6 (nervosnetwork#355)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* chore: rollback wait-on because it hangs in tcp connection

---------

Signed-off-by: Chen Yu <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashchan ashchan ashchan approved these changes

@duanyytop duanyytop duanyytop approved these changes

@classicalliu classicalliu classicalliu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Keith-CY @ashchan @duanyytop @classicalliu