-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable click max when address is empty. #2932
Conversation
Use placeholder address to generate tx.
/package |
When click max button repeatedly,an total amount will show non-inevitably and ui become abnormal. @yanguoyu 2023-11-15.10.37.41.mov |
How about click Max after syncing to 100%? |
When sync 100%,the balance does not change again and again,so abnormal ui does not show up.Is the reason? |
Maybe some transaction was not synced, then the max balance will be larger than the actual. |
An small strange point is that :when click max ,the total blance is filled.When click again,it shows like this: Maybe click max button second time has cancel input box number and come to primitive status like this is better,isn 't it ? @Danie0918 |
IMO, There are differences between |
For a button, its operation should match the description. There are 2 options here:
Personally, I prefer the second one, which allows the user to recapture the maximum value when their balance changes. |
Currently, the max button has two functions:
Do you mean we'd better cancel sending max by another action? @Danie0918 |
Canceling the maximum value can be manually modified or deleted by the user, and the max button should be to enter the maximum value.If the cancel function is implemented via a button, the button should change to cancel when clicked. IMO,The Max button should be entered as the maximum value even if it is clicked repeatedly. |
How about changing |
Okay, that's better. |
/package |
When language is Chinese it shows like this: 2023-11-17.11.07.31.movWhy not shows "最大值" in Chinese? |
The tips include
|
Refer to Magickbase/neuron-public-issues#308. Use placeholder address to generate tx.
enable-click-max.mov