Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show the migrate ckb data dialog #2869

Merged
merged 3 commits into from
Oct 17, 2023

Conversation

yanguoyu
Copy link
Collaborator

If we need to run ckb migrate for the ckb data, the neuron will show a dialog to help users migrate ckb data. Once users have selected migrate, the neuron will auto-migrate next time if the before-migrate version is the same. The migrating version will be saved in the electron local storage, if we want to show the migrate dialog again, we can delete the local storage, which can be found at /Users/${username}/Library/Application Support/Neuron/Local Storage.

migrateing.mov

@Keith-CY
Copy link
Collaborator

I remembered that migrating will be displayed where progress sat in the deprecated UI

@yanguoyu
Copy link
Collaborator Author

I remembered that migrating will be displayed where progress sat in the deprecated UI

Of course, may be because it was too fast that the migrating status was not shown. But I find the migrating status will not change to syncing status, I will fix it and upload the full process video.

@yanguoyu
Copy link
Collaborator Author

The full migration video:

migrate-full.mov

@yanguoyu yanguoyu requested a review from Keith-CY October 13, 2023 00:28
@silySuper
Copy link
Collaborator

silySuper commented Oct 13, 2023

/package
Packaging for test is done in 6503496425. @silySuper

@silySuper
Copy link
Collaborator

silySuper commented Oct 16, 2023

/package
Packaging for test is done in 6527826934. @silySuper

@silySuper
Copy link
Collaborator

@yanguoyu yanguoyu added this pull request to the merge queue Oct 17, 2023
Merged via the queue into nervosnetwork:develop with commit 62b11cc Oct 17, 2023
10 checks passed
@yanguoyu yanguoyu deleted the fix-migrate-dialog branch October 17, 2023 02:13
@Keith-CY Keith-CY mentioned this pull request Oct 17, 2023
@MarkoSARIC1990
Copy link

How can we do migration on Neuron, i cant understand from the video, thank you

@yanguoyu
Copy link
Collaborator Author

yanguoyu commented Nov 1, 2024

How can we do migration on Neuron, i cant understand from the video, thank you

Neuron should open a migration dialog for the user to choose to migrate if migration is needed. If the dialog does not show,
or we can manually migrate refer to #2868 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants