chore(CI): Add check story book to CI and update storybook to v7 #2747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yanguoyu
requested review from
Keith-CY,
homura,
WhiteMinds,
devchenyan and
alexsupa597
This was referenced Jun 28, 2023
WhiteMinds
approved these changes
Jun 28, 2023
yanguoyu
force-pushed
the
fix-storybook
branch
2 times, most recently
from
baa77f0 to
9f3180d
Compare
|
Packaging for test is done in 5398713945 for commit 9f3180d . |
Keith-CY
reviewed
Jun 28, 2023
| }, | ||
| webpackFinal: config => { | ||
| config.resolve.alias = { | ||
| ...config.resolve.alias, | ||
| electron: require.resolve('./electron') | ||
| } | ||
| return config | ||
| }; |
There was a problem hiding this comment.
Semicolons should be avoided.
Ref: https://github.com/nervosnetwork/neuron/blob/develop/packages/neuron-ui/.prettierrc.js#L6
|
Irrelevant updates about formatting should be avoided |
It will fail when running |
|
Packaging for test is done in 5399295918 for commit dca8e3f . |
|
Packaging for test is done in 5399505473 for commit f40903d . |
1 task
devchenyan
approved these changes
Jun 29, 2023
Gotcha |
Keith-CY
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of storybookjs/storybook#21642, v6.5.17-alpha.0 and v7 all fix this bug. So I update the storybook to v7.
And there are some deprecations from v6 to v7. https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#70-deprecations-and-default-changes. So I will open a new issue to resolve it.