-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Init wallet device. #2581
fix: Init wallet device. #2581
Conversation
An error is found and needs to be located. |
Fixed with e9b8939. |
After clicking |
It failed to get the firmware version failed, but it seems not to affect the functions. I have sent an issue to |
Is this error reproducible since we found |
From LedgerHQ/ledger-live#2583 (comment), I guess get_version.mov |
This error is not reproducible now. |
Cool, then please verify the function, and a conflict should be resolved before being merged @yanguoyu |
Is throwing this exception prompt as expected when the CKB App is not open on Ledger? @yanguoyu |
From my video, I guess yes. |
1. support create external buffers with electron/electron#36624 2. node-hid support electron 21 with node-hid/node-hid#486
be8d5e1
to
2f02570
Compare
How is it being tested @Cedar67 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified.
Environment:
Nano X
CKB app v0.5.5
sign-message-by-hardwallet.mov