Skip to content

Commit

Permalink
Merge branch 'develop' of https://github.com/nervosnetwork/neuron int…
Browse files Browse the repository at this point in the history
…o develop
  • Loading branch information
Keith-CY committed Mar 15, 2024
2 parents e1888d6 + 947f1e6 commit e25bf98
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion packages/neuron-wallet/src/services/node.ts
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,8 @@ class NodeService {
await stopMonitor('ckb')
const isDefaultCKBNeedStart = await this.isDefaultCKBNeedRestart()
if (isDefaultCKBNeedStart) {
if (SettingsService.getInstance().isFirstSync) {
const currentNetwork = NetworksService.getInstance().getCurrent()
if (SettingsService.getInstance().isFirstSync && currentNetwork.type === NetworkType.Default) {
logger.info("CKB:\tThis is the first sync, please wait for the user's confirmation")
return
}
Expand Down
2 changes: 1 addition & 1 deletion packages/neuron-wallet/tests/services/node.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -571,7 +571,7 @@ describe('NodeService', () => {
describe('test start default node', () => {
beforeEach(() => {
const NodeService = require('../../src/services/node').default
stubbedNetworsServiceGet.mockReturnValue({ remote: BUNDLED_CKB_URL, readonly: true })
stubbedNetworsServiceGet.mockReturnValue({ remote: BUNDLED_CKB_URL, readonly: true, type: 0 })
getLocalNodeInfoMock.mockRejectedValue('not start')
nodeService = new NodeService()
})
Expand Down

2 comments on commit e25bf98

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Packaging for test is done in 8297773384

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Packaging for test is done in 8297781275

Please sign in to comment.