Skip to content

Commit

Permalink
ci: specify macos version
Browse files Browse the repository at this point in the history
MacOS is specified by version number explicitly because tag
"macos-latest" refers to macos-11 or macos-12 randomly during
GitHub action's transition while macos 12 removed Python 2 which
is required by electron-builder.

Since latest electron-builder has supported python3, this hotfix
will not introduce python2 in host but downgrade it to macos 12

Ref: electron-userland/electron-builder#6606
  • Loading branch information
Keith-CY committed Dec 21, 2022
1 parent 90fbc2e commit 4275a3d
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
node:
- 16.10.0
os:
- macos-latest
- macos-11
- ubuntu-20.04
- windows-2019

Expand Down Expand Up @@ -67,7 +67,7 @@ jobs:
CI: false

- name: Package for MacOS
if: matrix.os == 'macos-latest'
if: matrix.os == 'macos-11'
run: |
./scripts/download-ckb.sh mac
yarn release mac
Expand Down Expand Up @@ -99,14 +99,14 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Upload Neuron App Zip
if: matrix.os == 'macos-latest'
if: matrix.os == 'macos-11'
uses: actions/upload-artifact@v2
with:
name: Neuron-Mac
path: release/Neuron-*-mac.zip

- name: Upload Neuron Dmg
if: matrix.os == 'macos-latest'
if: matrix.os == 'macos-11'
uses: actions/upload-artifact@v2
with:
name: Neuron-Dmg
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/package_for_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
node:
- 16.10.0
os:
- macos-latest
- macos-11
- ubuntu-20.04
- windows-2019

Expand Down Expand Up @@ -62,7 +62,7 @@ jobs:
CI: false

- name: Package for MacOS
if: matrix.os == 'macos-latest'
if: matrix.os == 'macos-11'
run: |
./scripts/download-ckb.sh mac
yarn package:test mac
Expand Down Expand Up @@ -94,14 +94,14 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Upload Neuron App Zip
if: matrix.os == 'macos-latest'
if: matrix.os == 'macos-11'
uses: actions/upload-artifact@v2
with:
name: Neuron-Mac
path: release/Neuron-*-mac.zip

- name: Upload Neuron Dmg
if: matrix.os == 'macos-latest'
if: matrix.os == 'macos-11'
uses: actions/upload-artifact@v2
with:
name: Neuron-Dmg
Expand Down

1 comment on commit 4275a3d

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Packaging for test is done in 3749349902

Please sign in to comment.