Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

chore: tips for running make ci before create PR #54

Merged
merged 1 commit into from
Dec 12, 2019
Merged

chore: tips for running make ci before create PR #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<!-- Thanks for sending a pull request! -->
<!-- Have I run `make ci`? -->

**What type of PR is this?**

Expand Down
7 changes: 4 additions & 3 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,10 @@ When contributing to this repository, please first discuss the change you wish t
1. Fork the `muta` repo and create your branch from master.
2. If you have added code that should be tested, add unit tests.
3. Verify and ensure that the test suite passes.
4. Make sure your code passes CI.
5. Ensure the PR description clearly describes the problem and solution. Include the relevant issue number if applicable.
6. Submit your pull request.
4. Run `make ci` to lint and test the code before commit.
5. Make sure your code passes CI.
6. Ensure the PR description clearly describes the problem and solution. Include the relevant issue number if applicable.
7. Submit your pull request.


## Code of Conduct
Expand Down