Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

fix(MultiSig)!: change interface and substitute adaptive_address for autonomy #384

Merged
merged 4 commits into from
Aug 4, 2020

Conversation

LycrusHamster
Copy link
Contributor

@LycrusHamster LycrusHamster commented Aug 2, 2020

What type of PR is this?

fix(multi-sig)!: change interface and substitute adaptive_address for autonomy

BREAKING CHANGE: the interface is changed and affect on all sdk/clients

What this PR does / why we need it:

due to the bech32 format, the adaptive address is not suitable.

so we add 'autonomy' field.

B.T.W. change the UpdateAccountPayload to make it non-ambigious
B.T.W. change the genesis payload to remove ambiguity.

Docs is here
https://github.com/HuobiGroup/huobi-chain-docs/pull/8

Java sdk:
nervosnetwork/muta-sdk-java#24

due to 2 different iteration, the pr of java sdk has been merged. This is a exclusion this time

Js sdk:

nervosnetwork/muta-sdk-js#23

@yejiayu
Copy link
Contributor

yejiayu commented Aug 3, 2020

/cc @KaoImin

@muta-robot muta-robot requested a review from KaoImin August 3, 2020 02:53
@KaoImin
Copy link

KaoImin commented Aug 4, 2020

I think the type of this PR is refactor rather than fix.

@yejiayu
Copy link
Contributor

yejiayu commented Aug 4, 2020

Will this PR have BRACKING_CHANGE?
Why does not add ! to the title?
Does the toolchain need to adapt?

@LycrusHamster @homura

@LycrusHamster LycrusHamster changed the title fix(multi-sig): change interface and substitute adaptive_address for autonomy fix(MultiSig)!: change interface and substitute adaptive_address for autonomy Aug 4, 2020
@LycrusHamster
Copy link
Contributor Author

LycrusHamster commented Aug 4, 2020

Will this PR have BRACKING_CHANGE?
Why does not add ! to the title?
Does the toolchain need to adapt?

@LycrusHamster @homura

Yes, now question mark has been added and BREAKING CHANGE have been explicitly add in the commit msg\

Yes, already dispatch sdk modification to java sdk and js sdk

@yejiayu
Copy link
Contributor

yejiayu commented Aug 4, 2020

/hold

Wait SDK adaption

homura added a commit to nervosnetwork/muta-sdk-js that referenced this pull request Aug 4, 2020
homura added a commit to nervosnetwork/muta-sdk-js that referenced this pull request Aug 4, 2020
@yejiayu
Copy link
Contributor

yejiayu commented Aug 4, 2020

/hold cancel

@yejiayu
Copy link
Contributor

yejiayu commented Aug 4, 2020

/lgtm

@LycrusHamster
Copy link
Contributor Author

/approve

@muta-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LycrusHamster, yejiayu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [LycrusHamster,yejiayu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@muta-robot muta-robot merged commit a58831e into nervosnetwork:master Aug 4, 2020
@LycrusHamster LycrusHamster deleted the fix-multisig branch August 4, 2020 15:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants