This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
feat(service)!: add authorization service for mempool #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Accept request. |
|
register multisig in DefaultServiceMapping |
|
Accept request. |
|
Accept request. |
|
Accept request. |
|
Accept request. |
homura
pushed a commit
to nervosnetwork/muta-sdk-js
that referenced
this pull request
Jun 23, 2020
supported mempool check sig with nervosnetwork/muta#320
test: update muta sdk version for checking multi sig with mempool cha…
|
Accept request. |
added 2 commits
June 23, 2020 17:37
|
Accept request. |
|
Accept request. |
|
Accept request. |
|
Accept request. |
test(e2e): add multi signature testcase
|
Accept request. |
LycrusHamster
previously approved these changes
Jun 24, 2020
| #[cycles(210_00)] | ||
| #[read] | ||
| fn check_authorization(&self, ctx: ServiceContext, payload: String) -> ServiceResponse<()> { | ||
| for (service_name, mathod_name) in self.verified_map.iter() { |
There was a problem hiding this comment.
spelling error mathod -> method
yejiayu
approved these changes
Jun 24, 2020
homura
added a commit
to nervosnetwork/muta-benchmark
that referenced
this pull request
Jun 25, 2020
homura
added a commit
to nervosnetwork/muta-benchmark
that referenced
this pull request
Sep 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
What this PR does / why we need it:
Add authorization service.
After adding the multi-signature service, the mempool will not be able to verify the signature of the transaction. Besides, there are some checking items that should be checked before inserting a transaction such as check the block list, check the account balance. This PR adds a service named authorization. Every check item except verification signature should be registered in genesis. The content in genesis is the name string of the service and the name string of the method. To be noticed that the payload type of the method must be
protocol::types::SignedTransaction.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: