Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

feat(executor): indenpendent tx hook states commit #316

Merged
merged 2 commits into from
Jun 28, 2020

Conversation

zeroqn
Copy link
Contributor

@zeroqn zeroqn commented Jun 11, 2020

What type of PR is this?
feat

What this PR does / why we need it:

Right now, tx panic will revert state changes in tx hook. This pr split tx execution into
thress phrases:

  • tx hook before
  • tx
  • tx hook after

All phrases can commit their changes independently.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@muta-bot
Copy link

muta-bot bot commented Jun 11, 2020

Accept request.

@muta-bot
Copy link

muta-bot bot commented Jun 11, 2020

Docker builded. "mutadev/muta:d237cca"
Run chaos test on k8s named "muta-pr316"

KaoImin
KaoImin previously approved these changes Jun 24, 2020
LycrusHamster
LycrusHamster previously approved these changes Jun 28, 2020
@zeroqn zeroqn dismissed stale reviews from LycrusHamster and KaoImin via 9f93455 June 28, 2020 07:02
@zeroqn zeroqn force-pushed the feat-commitable-tx-hook branch from d237cca to 9f93455 Compare June 28, 2020 07:02
Copy link
Contributor

@LycrusHamster LycrusHamster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@LycrusHamster LycrusHamster merged commit fde6450 into nervosnetwork:master Jun 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants