This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
refactor(store): change store map to iter #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Accept request. |
|
Docker builded. "mutadev/muta:cfe5760" |
|
Accept request. |
nolanxyg
reviewed
May 27, 2020
|
|
||
| use crate::binding::store::{get_bucket_index, Bucket, FixedBuckets, StoreError}; | ||
|
|
||
| pub struct NewStoreMap<S: ServiceState, K: FixedCodec + PartialEq, V: FixedCodec> { |
There was a problem hiding this comment.
Maybe the name "NewXXX" of struct not customary ?
|
Docker builded. "mutadev/muta:43fe1f5" |
|
added 2 commits
May 27, 2020 19:43
|
Accept request. |
|
Docker builded. "mutadev/muta:73ca278" |
|
|
Accept request. |
|
Accept request. |
|
Docker builded. "mutadev/muta:547f9ec" |
|
Accept request. |
|
Docker builded. "mutadev/muta:f74d8c7" |
|
Accept request. |
|
Docker builded. "mutadev/muta:9cf1a84" |
|
Accept request. |
|
Accept request. |
|
Docker builded. "mutadev/muta:9cf1a84" |
yejiayu
previously approved these changes
May 28, 2020
|
Accept request. |
|
Docker builded. "mutadev/muta:55d701a" |
yejiayu
approved these changes
May 28, 2020
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
refactor
What this PR does / why we need it:
change the vector into buckets to iter
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: