This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
refactor(protocol): impl fixed codec trait by proc macro #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanxyg
reviewed
Apr 2, 2020
yejiayu
reviewed
Apr 2, 2020
This can not work. The |
yejiayu
reviewed
Apr 7, 2020
| } | ||
| } | ||
|
|
||
| impl FixedCodec for usize { |
There was a problem hiding this comment.
The usize length differently on 32-bit and 64-bit systems, so it is not recommended.
Delete this code.
There was a problem hiding this comment.
I have already fixed the length of usize as 64 bytes.
added 10 commits
April 10, 2020 20:00
KaoImin
force-pushed
the
fixed_codec
branch
3 times, most recently
from
245e26a to
6a1a4b0
Compare
|
ping @yejiayu |
yejiayu
approved these changes
Apr 15, 2020
zeroqn
pushed a commit
to zeroqn/muta
that referenced
this pull request
Apr 22, 2020
…rk#240) * refactor: impl fixed codec trait by proc macro * upfrade fixed codec derive version * impl Fixedcodec for primitives types * feat: impl FixedCodec for primitive types * feat: impl FixedCodec for Bloom * change: codec Hex * refactor: encode and decode for Hex * cargo clippy * change: primitive codec * temp * feat: derive fixedcodec for transaction
zeroqn
pushed a commit
to zeroqn/muta
that referenced
this pull request
Apr 22, 2020
…rk#240) * refactor: impl fixed codec trait by proc macro * upfrade fixed codec derive version * impl Fixedcodec for primitives types * feat: impl FixedCodec for primitive types * feat: impl FixedCodec for Bloom * change: codec Hex * refactor: encode and decode for Hex * cargo clippy * change: primitive codec * temp * feat: derive fixedcodec for transaction
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
refactor
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: