This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't implement |
KaoImin
reviewed
Oct 15, 2019
KaoImin
reviewed
Oct 15, 2019
KaoImin
suggested changes
Oct 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs cargo fmt
ok |
not finished yet |
@zeroqn PTAL |
KaoImin
previously approved these changes
Oct 15, 2019
KaoImin
previously approved these changes
Oct 16, 2019
yejiayu
suggested changes
Oct 16, 2019
KaoImin
previously approved these changes
Oct 17, 2019
KaoImin
previously approved these changes
Oct 23, 2019
zeroqn
approved these changes
Oct 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yejiayu
approved these changes
Oct 23, 2019
yejiayu
pushed a commit
to yejiayu/muta
that referenced
this pull request
Oct 31, 2019
* feat(network): implement connection service * chore(network): replace assert with debug_assert Remove panic on release runtime
yejiayu
pushed a commit
to yejiayu/muta
that referenced
this pull request
Oct 31, 2019
* refactor(protocol): Add fixed codec * finish primitive transaction epoch * finish receipt * add test * run test case succeed * refactor fixed_codec * modify protocol/src/codec/tests * rebase and rm approve * add bench * fix ci * test size after encode * flat tx fixed_encode * flatten RawTransaction fixed_codec and impl action::call result::call * fix: style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
refactor
What this PR does / why we need it:
add fixed codec to protocol
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: