Skip to content
This repository has been archived by the owner on Sep 13, 2022. It is now read-only.

refactor(protocol): Add fixed codec #13

Merged
merged 14 commits into from
Oct 23, 2019
Merged

refactor(protocol): Add fixed codec #13

merged 14 commits into from
Oct 23, 2019

Conversation

nolanxyg
Copy link
Contributor

What type of PR is this?
refactor

What this PR does / why we need it:
add fixed codec to protocol

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@nolanxyg nolanxyg requested review from yejiayu and a team October 11, 2019 09:30
@yejiayu
Copy link
Contributor

yejiayu commented Oct 15, 2019

Don't implement FixedCodec for Tx Approve, because we don't need it in the executor2.0 design.

Copy link

@KaoImin KaoImin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs cargo fmt

@nolanxyg
Copy link
Contributor Author

Don't implement FixedCodec for Tx Approve, because we don't need it in the executor2.0 design.

ok

@nolanxyg
Copy link
Contributor Author

Needs cargo fmt

not finished yet

@yejiayu
Copy link
Contributor

yejiayu commented Oct 15, 2019

@zeroqn PTAL

KaoImin
KaoImin previously approved these changes Oct 15, 2019
KaoImin
KaoImin previously approved these changes Oct 16, 2019
protocol/src/fixed_codec/receipt.rs Outdated Show resolved Hide resolved
protocol/src/fixed_codec/receipt.rs Outdated Show resolved Hide resolved
protocol/src/fixed_codec/transaction.rs Outdated Show resolved Hide resolved
KaoImin
KaoImin previously approved these changes Oct 17, 2019
KaoImin
KaoImin previously approved these changes Oct 23, 2019
Copy link
Contributor

@zeroqn zeroqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KaoImin KaoImin merged commit 831aa65 into nervosnetwork:master Oct 23, 2019
yejiayu pushed a commit to yejiayu/muta that referenced this pull request Oct 31, 2019
* feat(network): implement connection service

* chore(network): replace assert with debug_assert

Remove panic on release runtime
yejiayu pushed a commit to yejiayu/muta that referenced this pull request Oct 31, 2019
* refactor(protocol): Add fixed codec

* finish primitive transaction epoch

* finish receipt

* add test

* run test case succeed

* refactor fixed_codec

* modify protocol/src/codec/tests

* rebase and rm approve

* add bench

* fix ci

* test size after encode

* flat tx fixed_encode

* flatten RawTransaction fixed_codec and impl action::call result::call

* fix: style
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants