This repository has been archived by the owner on Sep 13, 2022. It is now read-only.
feat(executor): allow cancel execution units through context #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Accept request. |
|
Docker builded. "mutadev/muta:548d621" |
KaoImin
previously approved these changes
Jun 24, 2020
zeroqn
force-pushed
the
feat-allow-cancel-execution-units-through-context
branch
from
548d621 to
1fc3bd8
Compare
Execution Flows: tx hook before units -----> tx unit -----> tx hook after units Once canceled, current execution state will be reverted, following units will not be executed. State changed before cacneled will be saved.
We can still use panic to revert changes
zeroqn
force-pushed
the
feat-allow-cancel-execution-units-through-context
branch
from
1fc3bd8 to
8c325e8
Compare
KaoImin
approved these changes
Jun 29, 2020
LycrusHamster
approved these changes
Jun 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feat
What this PR does / why we need it:
Right now, there is not way to cancel a tx execution. This pr provides a way to do
it through
ServiceContext.Execution Flows: ( PR #316
tx hook before units -----> tx unit -----> tx hook after units
Once canceled, following execution unit will not be executed.
Current execution changes will still be saved. We can still revert
those changes using panic.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Require PR #316