Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expiry check for rpc and HTLC forwarding #317

Merged
merged 27 commits into from
Nov 25, 2024

Conversation

chenyukang
Copy link
Collaborator

  • Add TLC expiry check
  • Replace u128 with u64 for timestamp in payment history

@chenyukang chenyukang force-pushed the yukang-add-expiry-check branch from 1fcb687 to cdc0a87 Compare November 19, 2024 01:59
src/rpc/README.md Outdated Show resolved Hide resolved
@chenyukang chenyukang force-pushed the yukang-add-expiry-check branch from f7999b2 to ac44cea Compare November 23, 2024 03:25
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 77.35849% with 24 lines in your changes missing coverage. Please review.

Project coverage is 46.62%. Comparing base (4ea7577) to head (40980df).

Files with missing lines Patch % Lines
src/rpc/invoice.rs 0.00% 8 Missing ⚠️
src/fiber/network.rs 78.12% 7 Missing ⚠️
src/fiber/channel.rs 70.58% 5 Missing ⚠️
src/cch/actor.rs 0.00% 2 Missing ⚠️
src/rpc/channel.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #317      +/-   ##
==========================================
- Coverage   46.63%   46.62%   -0.02%     
==========================================
  Files          45       45              
  Lines       28591    28642      +51     
==========================================
+ Hits        13333    13353      +20     
- Misses      15258    15289      +31     
Flag Coverage Δ
unittests 46.62% <77.35%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@quake quake merged commit 89c2483 into nervosnetwork:main Nov 25, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants