Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peer store optimization #4783

Merged
merged 4 commits into from
Jan 17, 2025
Merged

Peer store optimization #4783

merged 4 commits into from
Jan 17, 2025

Conversation

driftluo
Copy link
Collaborator

@driftluo driftluo commented Jan 15, 2025 •
edited
Loading

What problem does this PR solve?

  1. peer store only retains TCP multiaddr
  2. peer store support store DNS
  3. OutboundPeerService specifying the transport type, In wasm, user can specify ws or wss for dial operation
  4. identify/discovery allows no tcp/ip multiaddr spread
  5. public_listens allow no tcp/ip multiaddr
  6. Keep connected nodes up to date in the peer store
  7. Fix feeler flags fetch fail

Check List

Tests

  • Unit test
  • Integration test

Release note

Title Only: Include only the PR title in the release note.

@driftluo driftluo requested a review from a team as a code owner January 15, 2025 07:09
@driftluo driftluo requested review from doitian and removed request for a team January 15, 2025 07:09
eval-exec
eval-exec reviewed Jan 15, 2025
View reviewed changes
network/src/network.rs Outdated Show resolved Hide resolved
@driftluo driftluo force-pushed the peer-store-optimization branch from adc2175 to d7fd868 Compare January 15, 2025 07:19
@driftluo driftluo force-pushed the peer-store-optimization branch from d7fd868 to 4c828e4 Compare January 15, 2025 07:29
eval-exec
eval-exec previously approved these changes Jan 15, 2025
View reviewed changes
@driftluo driftluo force-pushed the peer-store-optimization branch 2 times, most recently from b0e7475 to 5e07ec2 Compare January 15, 2025 08:00
eval-exec
eval-exec reviewed Jan 15, 2025
View reviewed changes
network/src/network.rs Outdated Show resolved Hide resolved
eval-exec
eval-exec previously approved these changes Jan 15, 2025
View reviewed changes
@driftluo driftluo force-pushed the peer-store-optimization branch from 5e07ec2 to 60926de Compare January 15, 2025 09:01
quake
quake reviewed Jan 16, 2025
View reviewed changes
network/src/network.rs Outdated Show resolved Hide resolved
network/src/network.rs Outdated Show resolved Hide resolved
quake
quake reviewed Jan 16, 2025
View reviewed changes
network/src/peer_registry.rs Outdated Show resolved Hide resolved
network/src/peer_registry.rs Outdated Show resolved Hide resolved
@driftluo driftluo force-pushed the peer-store-optimization branch 2 times, most recently from 5179204 to eb75dfc Compare January 17, 2025 02:16
@driftluo driftluo force-pushed the peer-store-optimization branch from eb75dfc to e625cf0 Compare January 17, 2025 02:35
@gpBlockchain
Copy link
Collaborator

LGTM

@driftluo driftluo added this pull request to the merge queue Jan 17, 2025
@quake quake removed this pull request from the merge queue due to a manual request Jan 17, 2025
@quake quake merged commit b44d2d2 into nervosnetwork:develop Jan 17, 2025
32 checks passed
@driftluo driftluo deleted the peer-store-optimization branch January 17, 2025 07:14
@doitian doitian mentioned this pull request Jan 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake quake left review comments

@eval-exec eval-exec eval-exec approved these changes

@doitian doitian Awaiting requested review from doitian doitian is a code owner automatically assigned from nervosnetwork/ckb-dev

@chenyukang chenyukang Awaiting requested review from chenyukang

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad

Assignees
No one assigned
Labels
m:network
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@driftluo @gpBlockchain @quake @eval-exec