Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit txpool size when inserting an Entry #4390

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

chenyukang
Copy link
Collaborator

What problem does this PR solve?

Problem Summary:

Currently, the limit_size is only invoked by _update_tx_pool_for_reorg, so we only shrink tx_pool size when generating a new block. Ideally, we should also limit size when inserting a new Entry into pool.

What is changed and how it works?

What's Changed:
Invoke limit_size in submit_entry.

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • Performance regression
  • Breaking backward compatibility

Release note

Title Only: Include only the PR title in the release note.

@chenyukang chenyukang requested a review from a team as a code owner March 25, 2024 10:38
@chenyukang chenyukang requested review from quake and removed request for a team March 25, 2024 10:38
@chenyukang chenyukang force-pushed the limit-size branch 2 times, most recently from 734e925 to aee83a0 Compare March 25, 2024 10:42
@chenyukang chenyukang force-pushed the limit-size branch 2 times, most recently from ded02bb to b0d5704 Compare March 28, 2024 06:40
@chenyukang
Copy link
Collaborator Author

I ran a benchmark testing for this PR, seems there is no effect on TPS:

duration send tx tps 619,duration avg delay 12.895ms,sum tps:620

cc @gpBlockchain @zhangsoledad

@chenyukang chenyukang enabled auto-merge March 28, 2024 10:52
@chenyukang chenyukang added this pull request to the merge queue Mar 28, 2024
Merged via the queue into nervosnetwork:develop with commit a1730fe Mar 28, 2024
32 checks passed
@doitian doitian mentioned this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants