-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conflicts cache for tx_pool to record conflicted transactions #4339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenyukang
force-pushed
the
yukang-conflicted-pool
branch
2 times, most recently
from
February 1, 2024 10:15
598fa60
to
500a32b
Compare
eval-exec
reviewed
Feb 1, 2024
chenyukang
force-pushed
the
yukang-conflicted-pool
branch
2 times, most recently
from
February 5, 2024 05:51
bca49cc
to
fad9bd3
Compare
chenyukang
force-pushed
the
yukang-conflicted-pool
branch
2 times, most recently
from
February 7, 2024 12:33
9566108
to
f279cde
Compare
quake
reviewed
Feb 8, 2024
chenyukang
force-pushed
the
yukang-conflicted-pool
branch
3 times, most recently
from
February 19, 2024 10:15
7b85496
to
d0e74c7
Compare
chenyukang
force-pushed
the
yukang-conflicted-pool
branch
2 times, most recently
from
March 5, 2024 11:31
3611e18
to
9f5bd7d
Compare
Closed
1 task
chenyukang
force-pushed
the
yukang-conflicted-pool
branch
4 times, most recently
from
March 7, 2024 03:39
123a3a8
to
31263a2
Compare
eval-exec
previously approved these changes
Mar 7, 2024
chenyukang
force-pushed
the
yukang-conflicted-pool
branch
3 times, most recently
from
March 7, 2024 06:49
da11fc0
to
662ca3e
Compare
chenyukang
force-pushed
the
yukang-conflicted-pool
branch
from
March 7, 2024 10:52
535013a
to
f7a7703
Compare
doitian
previously approved these changes
Mar 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Mar 8, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Mar 8, 2024
chenyukang
force-pushed
the
yukang-conflicted-pool
branch
from
March 9, 2024 13:43
f7a7703
to
39daa1f
Compare
zhangsoledad
approved these changes
Mar 12, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
Starting from 112.0, we don't allow conflicted transactions stay in txpool at the same time, this may have a regression impact for compact block replay, since we reject any double-spending transaction when RBF is disable or RBF check failed.
What is changed and how it works?
We add a new pool called
conflicts_cache
intoTxPool
in this PR, we record the conflicted transaction in these scenarios:conflicts_cache
conflicts_cache
pre_check
, add the new transaction intoconflicts_cache
after verification.What's Changed:
Related changes
owner/repo
:Check List
Tests
Side effects
Release note