Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RBF fee and celldeps check rule issue with replaced txs and their descendants #4306

Merged

Conversation

chenyukang
Copy link
Collaborator

@chenyukang chenyukang commented Jan 18, 2024

What problem does this PR solve?

Problem Summary:

The current RBF fee check rules use the directly conflicted transactions' fee as compare target, but in the child-pay-for-parent scenario, the new transaction with fee large than root transactions but less than all descendant's sum may succeed in RBF rules.

The current celldep check also has a similar issue.

This PR will fix these 2 issue, by adding all the fee of descendants and root transactions and check the celldeps including descendants.

What is changed and how it works?

What's Changed:

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • Performance regression
  • Breaking backward compatibility

Release note

Title Only: Include only the PR title in the release note.

@chenyukang chenyukang requested a review from a team as a code owner January 18, 2024 07:24
@chenyukang chenyukang requested review from zhangsoledad and removed request for a team January 18, 2024 07:24
@chenyukang chenyukang force-pushed the yukang-fix-rbf-fee-rules branch from 619d8d7 to 355071c Compare January 18, 2024 07:54
@chenyukang chenyukang changed the title RBF fee check with replaced txs and their descendants RBF check fee and celldeps with replaced txs and their descendants Jan 23, 2024
@chenyukang chenyukang changed the title RBF check fee and celldeps with replaced txs and their descendants Fix RBF fee and celldeps check rule issue with replaced txs and their descendants Jan 23, 2024
@chenyukang chenyukang force-pushed the yukang-fix-rbf-fee-rules branch from 6e889fd to f9e7c75 Compare January 23, 2024 11:47
@gpBlockchain
Copy link
Collaborator

LGTM

@zhangsoledad zhangsoledad added this pull request to the merge queue Jan 25, 2024
Merged via the queue into nervosnetwork:develop with commit 2ceed95 Jan 25, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants