Fix RBF fee and celldeps check rule issue with replaced txs and their descendants #4306
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
The current RBF fee check rules use the directly conflicted transactions' fee as compare target, but in the child-pay-for-parent scenario, the new transaction with fee large than root transactions but less than all descendant's sum may succeed in RBF rules.
The current celldep check also has a similar issue.
This PR will fix these 2 issue, by adding all the fee of descendants and root transactions and check the celldeps including descendants.
What is changed and how it works?
What's Changed:
Related changes
owner/repo
:Check List
Tests
Side effects
Release note