Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(script): make update_caller_machine public #4052

Merged
merged 1 commit into from
Jun 30, 2023
Merged

chore(script): make update_caller_machine public #4052

merged 1 commit into from
Jun 30, 2023

Conversation

mohanson
Copy link
Contributor

What problem does this PR solve?

Problem Summary:

ckb-debugger cannot update the caller's data even though it got the paused spawn machine instance.

What is changed and how it works?

What's Changed:

Public update_caller_machine

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Release note 

Title Only: Include only the PR title in the release note.

@mohanson mohanson requested a review from a team as a code owner June 30, 2023 07:40
@mohanson mohanson requested review from doitian and removed request for a team June 30, 2023 07:40
@zhangsoledad zhangsoledad added this pull request to the merge queue Jun 30, 2023
@zhangsoledad zhangsoledad mentioned this pull request Jun 30, 2023
Merged
Merged via the queue into nervosnetwork:develop with commit 860d56c Jun 30, 2023
@doitian doitian mentioned this pull request Jul 3, 2023
Closed
@mohanson mohanson deleted the pubtypes branch July 13, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eval-exec eval-exec eval-exec approved these changes

@zhangsoledad zhangsoledad zhangsoledad approved these changes

@doitian doitian Awaiting requested review from doitian doitian is a code owner automatically assigned from nervosnetwork/ckb-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohanson @zhangsoledad @eval-exec