Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scripts): set_debug_printer should updates generator's debug_printer #4011

Merged
merged 1 commit into from
Jun 15, 2023
Merged

fix(scripts): set_debug_printer should updates generator's debug_printer #4011

merged 1 commit into from
Jun 15, 2023

Conversation

mohanson
Copy link
Contributor

What problem does this PR solve?

Problem Summary:

Calling set_debug_printer will have no effect.

The bug was introduced by this PR: 80b3d21#diff-7e2ff24bf0a62c374be4d4f63d0cbf77a8ca525883575b9ce4609cff1c7e81b8R441-R459

What is changed and how it works?

What's Changed:

  1. Remove TransactionScriptsVerifier's debug_printer member
  2. set_debug_printer now updates TransactionScriptsSyscallsGenerator's debug_printer

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

None: Exclude this PR from the release note.

@mohanson mohanson requested a review from a team as a code owner June 14, 2023 08:40
@mohanson mohanson requested review from quake and removed request for a team June 14, 2023 08:40
@eval-exec eval-exec requested a review from xxuejie June 14, 2023 08:47
@zhangsoledad zhangsoledad added this pull request to the merge queue Jun 15, 2023
Merged via the queue into nervosnetwork:develop with commit 0b8cff8 Jun 15, 2023
@zhangsoledad zhangsoledad mentioned this pull request Jun 16, 2023
Merged
@mohanson mohanson deleted the fix_set_debug_printer branch June 25, 2023 02:45
@doitian doitian mentioned this pull request Jun 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eval-exec eval-exec eval-exec approved these changes

@zhangsoledad zhangsoledad zhangsoledad approved these changes

@quake quake Awaiting requested review from quake quake is a code owner automatically assigned from nervosnetwork/ckb-dev

@xxuejie xxuejie Awaiting requested review from xxuejie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohanson @zhangsoledad @eval-exec