Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPC: Set jsonrpc::Ratio as the type of threshold field for DeploymentsInfo and Deployment #3980

Merged
merged 4 commits into from
May 12, 2023
Merged

RPC: Set jsonrpc::Ratio as the type of threshold field for DeploymentsInfo and Deployment #3980

merged 4 commits into from
May 12, 2023

Conversation

eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented May 12, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #3978

Problem Summary:

What is changed and how it works?

What's Changed:

Related changes

  • Add Ratio struct in ckb-jsonrpc crate
  • Set jsonrpc::Ratio as the type of threshold field for DeploymentsInfo and Deployment

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • It's a break change

Release note 

Title Only: Include only the PR title in the release note.

@eval-exec eval-exec changed the title add RPC: Set jsonrpc::Ratio as the type of threshold field for DeploymentsInfo and Deployment May 12, 2023
@eval-exec eval-exec marked this pull request as ready for review May 12, 2023 09:48
@eval-exec eval-exec requested a review from a team as a code owner May 12, 2023 09:48
@eval-exec eval-exec requested review from zhangsoledad and removed request for a team May 12, 2023 09:48
@eval-exec eval-exec added the b:rpc Break RPC interface label May 12, 2023
@eval-exec eval-exec self-assigned this May 12, 2023
@zhangsoledad zhangsoledad added this pull request to the merge queue May 12, 2023
Merged via the queue into nervosnetwork:develop with commit 7dbb260 May 12, 2023
@doitian doitian mentioned this pull request Jun 13, 2023
Closed
This was referenced Nov 23, 2023
Merged
Merged
This was referenced Aug 1, 2024
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangsoledad zhangsoledad zhangsoledad approved these changes

Assignees

@eval-exec eval-exec

Labels
b:rpc Break RPC interface
Projects
CKB Kanban
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The result of returning the number is not hexadecimal.
2 participants
@eval-exec @zhangsoledad