Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tx-pool remove expired #3894

Merged

Conversation

zhangsoledad
Copy link
Member

@zhangsoledad zhangsoledad commented Mar 21, 2023

What problem does this PR solve?

The tx-pool does not expire for all transactions

What is changed and how it works?

  • Fix the expiration of tx-pool
  • Tweak the default size limit of the tx-pool, the previous value was too small
  • Remove the max cycles limit of the tx-pool, the significance of the size limit is to control the memory usage, while for the cycles limit is not very meaningful, so it is removed.

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Performance regression
  • Breaking backward compatibility

Release note

Title Only: Include only the PR title in the release note.

@zhangsoledad zhangsoledad force-pushed the zhangsoledad/tx-size-limit branch from f261ac3 to 863135c Compare March 22, 2023 01:59
@zhangsoledad zhangsoledad force-pushed the zhangsoledad/tx-size-limit branch from 8f26824 to 7e46eac Compare March 22, 2023 03:01
@zhangsoledad zhangsoledad marked this pull request as ready for review March 22, 2023 03:07
@zhangsoledad zhangsoledad requested a review from a team as a code owner March 22, 2023 03:07
@zhangsoledad zhangsoledad requested review from quake and removed request for a team March 22, 2023 03:07
rpc/src/tests/error.rs Outdated Show resolved Hide resolved
tx-pool/src/process.rs Outdated Show resolved Hide resolved
test/template/ckb.toml Outdated Show resolved Hide resolved
@zhangsoledad zhangsoledad force-pushed the zhangsoledad/tx-size-limit branch from 761c5d4 to 026537b Compare March 22, 2023 09:31
@zhangsoledad zhangsoledad force-pushed the zhangsoledad/tx-size-limit branch from 026537b to 72918fb Compare March 22, 2023 09:34
@doitian
Copy link
Member

doitian commented Mar 22, 2023

Suggest to add a new RPC method to get the minimal fee rate to enter the pool.

@zhangsoledad
Copy link
Member Author

zhangsoledad commented Mar 22, 2023

Suggest to add a new RPC method to get the minimal fee rate to enter the pool.

https://github.com/nervosnetwork/ckb/tree/develop/rpc#method-tx_pool_info
With the RPC tx_pool_info to get the min_fee_rate, do you think we still need a separate rpc to provide min_fee_rate?

@doitian
Copy link
Member

doitian commented Mar 22, 2023

Suggest to add a new RPC method to get the minimal fee rate to enter the pool.

https://github.com/nervosnetwork/ckb/tree/develop/rpc#method-tx_pool_info With the RPC tx_pool_info to get the min_fee_rate, do you think we still need a separate rpc to provide min_fee_rate?

It's enough. But this RPC lacks of the max size cycles info.

@zhangsoledad
Copy link
Member Author

Suggest to add a new RPC method to get the minimal fee rate to enter the pool.

https://github.com/nervosnetwork/ckb/tree/develop/rpc#method-tx_pool_info With the RPC tx_pool_info to get the min_fee_rate, do you think we still need a separate rpc to provide min_fee_rate?

It's enough. But this RPC lacks of the max size cycles info.

added

@zhangsoledad zhangsoledad added this pull request to the merge queue Mar 23, 2023
@zhangsoledad zhangsoledad merged commit 26e3fdd into nervosnetwork:develop Mar 23, 2023
@zhangsoledad zhangsoledad deleted the zhangsoledad/tx-size-limit branch March 23, 2023 07:42
@doitian doitian mentioned this pull request Apr 13, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants