fix(rpc): return the cycles of the first non-cellbase transaction as cellbase's cycles #3763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangby-cryptape
requested review from
zhangsoledad
and removed request for
a team
eval-exec
reviewed
Dec 20, 2022
Yes, I missed. I will update this PR. |
…cellbase's cycles
yangby-cryptape
force-pushed
the
pr/fix-cellbase-cycles
branch
from
a44b575 to
50cb412
Compare
eval-exec
approved these changes
Dec 20, 2022
zhangsoledad
approved these changes
Dec 21, 2022
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 22, 2022
3770: [backport] fix(rpc): return the cycles of the first non-cellbase transaction as cellbase's cycles r=quake a=yangby-cryptape ### What problem does this PR solve? Backport #3763. ### Check List Tests - Unit test - Integration test - Manual test (add detailed scripts or steps below) - No code ci-runs-only: [ quick_checks,linters ] ### Release note ```release-note Title Only: Include only the PR title in the release note. ``` Co-authored-by: Boyu Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
When call the RPC method
get_transaction:If a block has no non-cellbase transactions, the cycles of its cellbase are null.
e.g.:
If a block has at least one non-cellbase transactions, the cycles of its cellbase are the same as the first non-cellbase transaction.
Since
0.saturating_sub(1) == 1.saturating_sub(1) == 0in the follow code:ckb/rpc/src/module/chain.rs
Lines 2034 to 2036 in adcfac4
e.g.:
If I understood correctly, the cycles for cellbases should always be null.
Check List
Tests
Release note