perf: regex new is expensive #2982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangsoledad
approved these changes
Aug 26, 2021
yangby-cryptape
approved these changes
Aug 26, 2021
|
bors r=yangby-cryptape,zhangsoledad |
bors bot
added a commit
that referenced
this pull request
Aug 26, 2021
2982: perf: regex new is expensive r=yangby-cryptape,zhangsoledad a=driftluo ### What problem does this PR solve? regex new is expensive，reinitialization every time enter the function is not a good strategy ### What is changed and how it works? use once_cell to wrapper regex ### Release note ```release-note Title Only: Include only the PR title in the release note. ``` Co-authored-by: driftluo <[email protected]>
|
Build failed: |
|
bors r=yangby-cryptape,zhangsoledad |
|
Build succeeded: |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
regex new is expensive，reinitialization every time enter the function is not a good strategy
What is changed and how it works?
use once_cell to wrapper regex
Release note