fix(metrics): there is no reactor running #2897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangby-cryptape
requested review from
keroro520,
quake and
zhangsoledad
as code owners
keroro520
previously approved these changes
Aug 3, 2021
zhangsoledad
changed the title
zhangsoledad
reviewed
Aug 3, 2021
| synchronizer.shared().state().tip_synced(&mut state); | ||
| let mut state_guard = peers.state.write(); | ||
| let state = state_guard.get_mut(&sync_protected_peer).unwrap(); | ||
| synchronizer.shared().state().tip_synced(state); |
zhangsoledad
previously approved these changes
Aug 3, 2021
|
Try to checkout ci.yaml from develop branch to see whether it works in rc/v0.43 |
doitian
requested changes
Aug 4, 2021
yangby-cryptape
added
the
s:waiting-on-author
yangby-cryptape
dismissed stale reviews from zhangsoledad and keroro520
via
ea215cd
yangby-cryptape
added
s:waiting-on-reviewers
doitian
approved these changes
Aug 6, 2021
driftluo
approved these changes
Aug 7, 2021
|
bors r=doitian,driftluo |
bors bot
added a commit
that referenced
this pull request
Aug 7, 2021
2897: fix(metrics): there is no reactor running r=doitian,driftluo a=yangby-cryptape Co-authored-by: Boyu Yang <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into rc/v0.43. It will not be retried. Additional information: {"message":"Waiting on code owner review from keroro520, quake, and/or zhangsoledad.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.