chore: code cleanup for db trait #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doitian
reviewed
Feb 24, 2019
| @@ -164,7 +164,7 @@ fn new_chain() -> ( | |||
| let shared = SharedBuilder::<CacheDB<RocksDB>>::default() | |||
| .db(&DBConfig { | |||
| path: db_dir.path().to_owned(), | |||
| rocksdb: None, | |||
| options: None, | |||
There was a problem hiding this comment.
In my opinion, rocksdb is better.
There was a problem hiding this comment.
I want to reuse the DBConfig in other backend db, e.g. LMDB: SharedBuilder::<CacheDB<Lmdb>>::default()..., so renamed it to options
doitian
approved these changes
Feb 26, 2019
bors bot
added a commit
that referenced
this pull request
Jan 4, 2021
2490: chore: upgrade tentacle r=quake,yangby-cryptape a=driftluo
Features
Add protocol spawn feature(#278)
Revert yamux buffer(#281)
Remove secp256k1 wasm compatible(#282)
Add doc(#289)
Bug Fix
Unified substream error output(#287)
Fix some msg left on buffer(#288)
Change blocking session detection(#290)
Co-authored-by: driftluo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.