Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hardfork): add a new field "hardfork_features" to the return of RPC method "get_consensus" #2879

Merged
merged 1 commit into from
Aug 5, 2021
Merged

feat(hardfork): add a new field "hardfork_features" to the return of RPC method "get_consensus" #2879

merged 1 commit into from
Aug 5, 2021

Conversation

yangby-cryptape
Copy link
Collaborator

No description provided.

@yangby-cryptape yangby-cryptape marked this pull request as ready for review July 28, 2021 04:38
@yangby-cryptape yangby-cryptape requested a review from a team as a code owner July 28, 2021 04:38
doitian
doitian reviewed Jul 30, 2021
View reviewed changes
rpc/README.md Outdated Show resolved Hide resolved
@yangby-cryptape yangby-cryptape added the s:waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. label Jul 30, 2021
@doitian doitian added s:waiting-on-reviewers Status: Waiting for Review s:waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. and removed s:waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. s:waiting-on-reviewers Status: Waiting for Review labels Jul 30, 2021
@yangby-cryptape yangby-cryptape added s:waiting-on-reviewers Status: Waiting for Review and removed s:waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. labels Jul 30, 2021
doitian
doitian previously approved these changes Jul 30, 2021
View reviewed changes
@quake
Copy link
Member

quake commented Jul 31, 2021

I think these two rpc should be merged into get_consensus rpc.

@yangby-cryptape yangby-cryptape changed the title feat(hardfork): add two new RPC methods to get hardfork features information feat(hardfork): add a new field "hardfork_features" to the return of RPC method "get_consensus" Aug 2, 2021
quake
quake previously approved these changes Aug 2, 2021
View reviewed changes
doitian
doitian requested changes Aug 4, 2021
View reviewed changes
rpc/README.md Outdated Show resolved Hide resolved
@yangby-cryptape yangby-cryptape added s:waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. and removed s:waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. labels Aug 4, 2021
doitian
doitian reviewed Aug 4, 2021
View reviewed changes
rpc/README.md Outdated Show resolved Hide resolved
@yangby-cryptape yangby-cryptape added the s:waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. label Aug 4, 2021
@yangby-cryptape yangby-cryptape removed the s:waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. label Aug 4, 2021
@doitian
Copy link
Member

doitian commented Aug 5, 2021

bors r=quake,doitian,keroro520

@bors
Copy link
Contributor

bors bot commented Aug 5, 2021

Build succeeded:

@bors bors bot merged commit 98de4d9 into nervosnetwork:develop Aug 5, 2021
@yangby-cryptape yangby-cryptape removed the s:waiting-on-reviewers Status: Waiting for Review label Aug 5, 2021
@yangby-cryptape yangby-cryptape deleted the pr/new-rpc-methods branch August 5, 2021 07:00
@doitian doitian mentioned this pull request Aug 10, 2021
Closed
3 tasks
Keith-CY added a commit to ckb-js/ckb-sdk-js that referenced this pull request Aug 30, 2021
@Keith-CY
feat(rpc): add a new field 'hardforkFeatures' in response of getConse…
133fe26 
…nsus

Add a new field 'hardforkFeatures' in response of getConsensus

BREAKING CHANGE: Add a new field 'hardforkFeatures' in response of getConsensus

ref nervosnetwork/ckb#2879
@Keith-CY Keith-CY mentioned this pull request Aug 30, 2021
Merged
@doitian doitian mentioned this pull request Sep 3, 2021
Closed
@Keith-CY Keith-CY mentioned this pull request Oct 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake quake approved these changes

@doitian doitian doitian approved these changes

@keroro520 keroro520 keroro520 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yangby-cryptape @quake @doitian @keroro520