fix: don't panic when the database is created by a higher version executable binary #2877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will backport this PR to branch "rc/v0.43" after it merged. |
yangby-cryptape
changed the title
driftluo
approved these changes
Jul 28, 2021
This comment has been minimized.
This comment has been minimized.
liya2017
approved these changes
Jul 29, 2021
doitian
reviewed
Jul 30, 2021
|
bors r=doitian,driftluo,liya2017 |
|
Build succeeded: |
yangby-cryptape
removed
the
s:waiting-on-ci
bors bot
added a commit
that referenced
this pull request
Aug 2, 2021
2878: chore(hardfork): bump db migrate version for the new column family of block extension data r=doitian,quake a=yangby-cryptape This PR is useless, unless the PR #2877 was backported to branch "rc/v0.43". 2889: ci: trigger ci on push specific branches r=liya2017,yangby-cryptape a=doitian If we trigger on a branch and later skip the ci workflow, GitHub consider it as passed. Side effect: forks cannot trigger this workflow other than the specific branches. 2890: chore: update README ci badges r=yangby-cryptape,quake a=doitian * Specify branch explicitly * Add query filter to the links Co-authored-by: Boyu Yang <[email protected]> Co-authored-by: ian <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits
fix: don't panic when the database is created by a higher version executable binary
fix: the sub-command
runshouldn't skip the fast migrationsThis bug doesn't affect any old versions because there is no fast migrations in old versions.
Ref: What are fast migrations?.