feat: add network protocol config #2641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quake
requested review from
doitian,
yangby-cryptape and
zhangsoledad
as code owners
quake
force-pushed
the
quake/network-protocol-config
branch
2 times, most recently
from
776d300 to
7064922
Compare
|
Can one of the admins verify this patch? |
driftluo
reviewed
Apr 22, 2021
quake
force-pushed
the
quake/network-protocol-config
branch
from
7064922 to
681a5be
Compare
driftluo
previously approved these changes
Apr 26, 2021
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
quake
force-pushed
the
quake/network-protocol-config
branch
from
681a5be to
a3e42ed
Compare
zhangsoledad
approved these changes
Jul 30, 2021
|
rebased with develop, please review again. |
driftluo
approved these changes
Jul 30, 2021
|
bors r=zhangsoledad,driftluo |
|
Build succeeded: |
Closed
bors bot
added a commit
that referenced
this pull request
Oct 23, 2021
3114: chore: warn incomplete supported network protocols r=zhangsoledad,driftluo a=keroro520 <!-- Thank you for contributing to nervosnetwork/ckb! If you haven't already, please read [CONTRIBUTING](https://github.com/nervosnetwork/ckb/blob/develop/CONTRIBUTING.md) document. If you're unsure about anything, just ask; somebody should be along to answer within a day or two. PR Title Format: 1. module [, module2, module3]: what's changed 2. *: what's changed --> ### What is changed and how it works? What's Changed: Added a warning log for enabling incomplete network protocols. The logs are helpful for investigating. ### Related changes - PR to update `owner/repo`: #2641 ### Check List <!--REMOVE the items that are not applicable--> Tests <!-- At least one of them must be included. --> - No code (skip ci) ### Release note <!-- Choose from None, Title Only and Note. Bugfixes or new features need a release note. --> ```release-note None: Exclude this PR from the release note. ``` 3136: fix: InvalidHeaderDep wait_for_tx_pool r=quake,yangby-cryptape a=zhangsoledad <!-- Thank you for contributing to nervosnetwork/ckb! If you haven't already, please read [CONTRIBUTING](https://github.com/nervosnetwork/ckb/blob/develop/CONTRIBUTING.md) document. If you're unsure about anything, just ask; somebody should be along to answer within a day or two. PR Title Format: 1. module [, module2, module3]: what's changed 2. *: what's changed --> ### What problem does this PR solve? integration-test InvalidHeaderDep random failed. ### What is changed and how it works? What's Changed: wait tx-pool state sync with chain. ### Check List <!--REMOVE the items that are not applicable--> Tests <!-- At least one of them must be included. --> - Integration test ### Release note <!-- Choose from None, Title Only and Note. Bugfixes or new features need a release note. --> ```release-note None: Exclude this PR from the release note. ``` 3137: chore: update platform support tier r=quake,yangby-cryptape a=doitian - chore: drop Ubuntu Xenial support - chore: remove Windows experimental notice ### What problem does this PR solve? Problem Summary: Platform tiers information is outdated. ### Check List <!--REMOVE the items that are not applicable--> Tests <!-- At least one of them must be included. --> - No code ci-runs-only: [ quick_checks,linters ] ### Release note <!-- Choose from None, Title Only and Note. Bugfixes or new features need a release note. --> ```release-note None: Exclude this PR from the release note. ``` 3138: docs: Update get-ckb link names in README.md r=quake,yangby-cryptape a=doitian ### What problem does this PR solve? Problem Summary: "Get CKB" is not a good name since the doc also tells how to build CKB. ### What is changed and how it works? What's Changed: Update the link names. ### Check List <!--REMOVE the items that are not applicable--> Tests <!-- At least one of them must be included. --> - No code ci-runs-only: [ quick_checks,linters ] ### Release note <!-- Choose from None, Title Only and Note. Bugfixes or new features need a release note. --> ```release-note None: Exclude this PR from the release note. ``` Co-authored-by: keroro <[email protected]> Co-authored-by: zhangsoledad <[email protected]> Co-authored-by: ian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is designed for testing and use of ckb-network crate by third party code, allows user to customize network protocols, for example, only open sync protocol in full node: