feat: Add multisig system script cell #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjyr
force-pushed
the
p2sh-multisig-system-script
branch
2 times, most recently
from
9495bf5 to
267d99c
Compare
jjyr
force-pushed
the
p2sh-multisig-system-script
branch
from
267d99c to
ba7d1d7
Compare
jjyr
changed the title
![nervos-bot[bot]](https://avatars.githubusercontent.com/in/22976?s=60&v=4){kind=small}
doitian
reviewed
Oct 29, 2019
script/src/syscalls/mod.rs
Outdated
| @@ -31,9 +31,9 @@ pub const ITEM_MISSING: u8 = 2; | |||
| pub const SLICE_OUT_OF_BOUND: u8 = 3; | |||
|
|
|||
| pub const LOAD_TRANSACTION_SYSCALL_NUMBER: u64 = 2051; | |||
| pub const LOAD_SCRIPT_SYSCALL_NUMBER: u64 = 2052; | |||
There was a problem hiding this comment.
Why change the syscall number? cc @xxuejie
There was a problem hiding this comment.
To keep syscall number consistent, the number 205x is used to describe load the whole struct, and 206x is used to describe load the hash of the struct.
|
Please rebase onto the latest change in nervosnetwork/ckb-system-scripts#60 |
jjyr
changed the title
xxuejie
approved these changes
Oct 29, 2019
doitian
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nervosnetwork/ckb-system-scripts#60