Save all dirty memory pages (including executable pages) and it's flag to snapshot #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quake
previously approved these changes
Nov 15, 2021
xxuejie
previously approved these changes
Nov 15, 2021
bors bot
added a commit
to nervosnetwork/ckb
that referenced
this pull request
Nov 15, 2021
3176: Fix: add dirty flag when load cell data as code r=yangby-cryptape,quake a=mohanson Solve the problem that 'load_data_cell_as_code' cannot work with 'ckb-vm chunk run' ref: nervosnetwork/ckb-vm#218 Co-authored-by: mohanson <[email protected]>
xxuejie
approved these changes
Nov 15, 2021
mohanson
changed the title
bors bot
added a commit
to nervosnetwork/ckb
that referenced
this pull request
Nov 16, 2021
3177: fix: upgrade ckb-vm to fix snapshot behavior r=yangby-cryptape,mohanson,zhangsoledad a=driftluo ### What problem does this PR solve? chunk run with the snapshot unable to support the binary replacement behavior of exec, which will cause abnormal behavior after resume. The upgraded VM supports backing up the current code(executable pages) to the snapshot to fix the above problems. nervosnetwork/ckb-vm#218 and #3176 should keep its behavior until hardfork activated ### Check List Tests - Unit test - Integration test ### Release note ```release-note Title Only: Include only the PR title in the release note. ``` Co-authored-by: driftluo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When making a snapshot, the code loaded by
load_cell_data_as_codeandexecsyscall in ckb could not be persisted. This bug caused an error in the ckb chunk_run function.ref: nervosnetwork/ckb#3176