chore: Assorted cleanup work #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove dummy-libc and rustc-dep-of-std features, since ckb-contract-toolchains has been deprecated, we are not using patched Rust with `target_os = ckb` anymore * dlopen-c is no longer a default feature, notice there is implication to this: dlopen-c as a feature used to help us bring in libc implementations. When simply removing dlopen-c, some contracts might break due to not having libc impls. This change adds another default feature `libc` which preserves a linked-by-default libc impl. This way, dlopen-c can be safely removed from default feature set
quake
approved these changes
Jan 2, 2024
XuJiandong
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
target_os = ckbanymorelibcwhich preserves a linked-by-default libc impl. This way, dlopen-c can be safely removed from default feature set