Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RPC Support for ckb v0.109 -> 0.117 #221

Merged
merged 12 commits into from
Aug 13, 2024
Merged

Add RPC Support for ckb v0.109 -> 0.117 #221

merged 12 commits into from
Aug 13, 2024

Conversation

eval-exec
Copy link
Contributor

@eval-exec eval-exec commented Aug 4, 2024 •
edited
Loading

Fix #220

@eval-exec eval-exec marked this pull request as draft August 4, 2024 01:03
@eval-exec eval-exec force-pushed the exec/support-many-rpc branch from afaaa78 to 8858d3c Compare August 4, 2024 06:14
@eval-exec eval-exec changed the title Support many rpc Support many rpc for ckb v0.109.0 Aug 4, 2024
@eval-exec eval-exec force-pushed the exec/support-many-rpc branch from 8858d3c to 5a7ed70 Compare August 4, 2024 06:31
@eval-exec eval-exec changed the title Support many rpc for ckb v0.109.0 Add RPC Support for ckb v0.109.0 Aug 4, 2024
@eval-exec eval-exec force-pushed the exec/support-many-rpc branch from ac786a7 to 53c33e0 Compare August 4, 2024 06:45
@eval-exec eval-exec changed the title Add RPC Support for ckb v0.109.0 Add RPC Support for ckb v0.109 -> 0.110 Aug 4, 2024
@eval-exec eval-exec marked this pull request as ready for review August 4, 2024 07:01
@eval-exec eval-exec changed the title Add RPC Support for ckb v0.109 -> 0.110 Add RPC Support for ckb v0.109 -> 0.111 Aug 4, 2024
@eval-exec eval-exec marked this pull request as draft August 4, 2024 07:02
@eval-exec eval-exec force-pushed the exec/support-many-rpc branch from be9a26b to 9eb6cda Compare August 8, 2024 13:24
@eval-exec eval-exec changed the title Add RPC Support for ckb v0.109 -> 0.111 Add RPC Support for ckb v0.109 -> 0.117 Aug 8, 2024
@eval-exec eval-exec marked this pull request as ready for review August 8, 2024 13:25
@eval-exec eval-exec force-pushed the exec/support-many-rpc branch from 9eb6cda to 2bd6b87 Compare August 9, 2024 06:47
@eval-exec
Copy link
Contributor Author

eval-exec commented Aug 9, 2024 •
edited
Loading

@quake Please help me execute the workflows
image

@eval-exec eval-exec requested a review from quake August 9, 2024 06:54
@eval-exec
Copy link
Contributor Author 

go: downloading github.com/aristanetworks/goarista v0.0.0-20170210015632-ea17b1a17847
go: downloading golang.org/x/sys v0.0.0-[20](https://github.com/nervosnetwork/ckb-sdk-go/actions/runs/10314934806/job/28555511295?pr=221#step:4:21)220422013727-9388b58f7150
ok  	github.com/nervosnetwork/ckb-sdk-go/v2/address	0.026s
# github.com/nervosnetwork/ckb-sdk-go/v2/transaction/signer_test [github.com/nervosnetwork/ckb-sdk-go/v2/transaction/signer.test]
Error: transaction/signer/example_test.go:20:44: not enough arguments in call to ctx.rpc.GetLiveCell
	have (context.Context, *types.OutPoint, bool)
	want (context.Context, *types.OutPoint, bool, *bool)
ok  	github.com/nervosnetwork/ckb-sdk-go/v2/collector	2.405s

Don't know why the test failed. I can't find example_test.go file.

@eval-exec
Copy link
Contributor Author

@quake Please rerun the failed CI workflow.

@eval-exec eval-exec force-pushed the exec/support-many-rpc branch from 2bd6b87 to 29c30c9 Compare August 9, 2024 11:16
@eval-exec
Copy link
Contributor Author 

go: downloading github.com/aristanetworks/goarista v0.0.0-20170210015632-ea17b1a17847
go: downloading golang.org/x/sys v0.0.0-[20](https://github.com/nervosnetwork/ckb-sdk-go/actions/runs/10314934806/job/28555511295?pr=221#step:4:21)220422013727-9388b58f7150
ok  	github.com/nervosnetwork/ckb-sdk-go/v2/address	0.026s
# github.com/nervosnetwork/ckb-sdk-go/v2/transaction/signer_test [github.com/nervosnetwork/ckb-sdk-go/v2/transaction/signer.test]
Error: transaction/signer/example_test.go:20:44: not enough arguments in call to ctx.rpc.GetLiveCell
	have (context.Context, *types.OutPoint, bool)
	want (context.Context, *types.OutPoint, bool, *bool)
ok  	github.com/nervosnetwork/ckb-sdk-go/v2/collector	2.405s

Don't know why the test failed. I can't find example_test.go file.

Rebased, I beleave CI will success now. @quake

@eval-exec
Copy link
Contributor Author

@quake I commented TestGetCellsMaxLimit, fix it later.

@quake quake merged commit 81d4efa into nervosnetwork:v2 Aug 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake Awaiting requested review from quake

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New RPC methods for ckb version 0.109.0-0.117.0
2 participants
@eval-exec @quake