Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve cell filter bug when chain txs are committed in same block #184

Merged

Conversation

quake
Copy link
Member

@quake quake commented Jan 20, 2024

resolve #183 and #181

@quake quake requested a review from yangby-cryptape January 20, 2024 05:22
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5fc2a81) 71.87% compared to head (5d460ff) 71.89%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #184      +/-   ##
===========================================
+ Coverage    71.87%   71.89%   +0.02%     
===========================================
  Files           25       25              
  Lines         6606     6612       +6     
===========================================
+ Hits          4748     4754       +6     
  Misses        1858     1858              
Flag Coverage Δ
unittests 71.89% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quake quake merged commit 789b08c into nervosnetwork:develop Jan 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[get_cell] get_cell is wrong
3 participants