Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve update script block number error #165

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

quake
Copy link
Member

@quake quake commented Dec 15, 2023

we are using the matched_blocks lock to avoiding concurrent update scrtips' filtered block number:

let mut matched_blocks = self.swc.matched_blocks().write().expect("poisoned");

however, the lock scope is too small when processing the BlockFilters message, it results in concurrent updates to the same scripts' filtered block number:

@quake quake marked this pull request as ready for review December 15, 2023 10:47
@quake quake merged commit e0a060a into nervosnetwork:develop Dec 15, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants