Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ckb dependencies to 0.111.0, use cargo-nextest to run unit tests #153

Conversation

eval-exec
Copy link
Contributor

@eval-exec eval-exec commented Oct 7, 2023

This PR do these changes;

  1. chrry-picked ac8b3c9
  2. use cargo nextest run to run unit tests

@eval-exec
Copy link
Contributor Author

eval-exec commented Oct 7, 2023

@quake Please help me trigger the CI action. I want to know if my changes can make the CI on the Windows platform successfully complete.

@eval-exec eval-exec changed the title [WIP] Fix NetworkServer not dropped in unit test [WIP] Fix NetworkServer not exit in unit test Oct 7, 2023
@eval-exec eval-exec force-pushed the exec/stop-services-when-controller-dropped branch from c574b80 to 1d87316 Compare October 7, 2023 08:37
@eval-exec eval-exec changed the title [WIP] Fix NetworkServer not exit in unit test Upgrade ckb dependencies to 0.111.0, use cargo-nextest to run unit tests Oct 7, 2023
@eval-exec
Copy link
Contributor Author

eval-exec commented Oct 7, 2023

@quake Please re-trigger the CI action.

@codecov-commenter
Copy link

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (5d33576) 69.92% compared to head (1d87316) 69.78%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #153      +/-   ##
===========================================
- Coverage    69.92%   69.78%   -0.15%     
===========================================
  Files           25       25              
  Lines         6375     6395      +20     
===========================================
+ Hits          4458     4463       +5     
- Misses        1917     1932      +15     
Flag Coverage Δ
unittests 69.78% <41.02%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...s/light_client/components/send_last_state_proof.rs 93.21% <ø> (ø)
src/verify.rs 91.48% <100.00%> (+0.47%) ⬆️
src/service.rs 64.73% <0.00%> (ø)
src/subcmds.rs 0.00% <0.00%> (ø)
src/storage.rs 95.89% <0.00%> (-1.00%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quake quake merged commit 578dcc6 into nervosnetwork:develop Oct 7, 2023
6 checks passed
@homura
Copy link

homura commented Oct 9, 2023

Hi, is there a plan to create a release for this PR?

@quake
Copy link
Member

quake commented Oct 9, 2023

we are testing this PR, but we don't have a confirmed release date yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants